diff --git a/.eslintrc.js b/.eslintrc.js index 9cc48ff1..9bbfd329 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -23,7 +23,12 @@ module.exports = { 'ember/avoid-leaking-state-in-ember-objects': 'off', 'ember/closure-actions': 'off', 'ember/use-brace-expansion': 'off', - 'ember/no-jquery': 'error' + 'ember/no-get': 'warn', + 'ember/no-get-with-default': 'warn', + 'ember/no-jquery': 'error', + 'ember/no-private-routing-service': 'warn', + 'ember/require-computed-property-dependencies': 'warn', + 'ember/use-ember-data-rfc-395-imports': 'warn' }, overrides: [ // tests diff --git a/.template-lintrc.js b/.template-lintrc.js index 8348be4b..dfad4ae0 100644 --- a/.template-lintrc.js +++ b/.template-lintrc.js @@ -2,36 +2,12 @@ module.exports = { pending: [ - { - "moduleId": "app/components/addon-review-form", - "only": [ - "no-action" - ] - }, - { - "moduleId": "app/components/addon-source-usages", - "only": [ - "no-action" - ] - }, - { - "moduleId": "app/components/addon-version-list", - "only": [ - "no-action" - ] - }, { "moduleId": "app/components/admin-addon-review-form", "only": [ "no-action" ] }, - { - "moduleId": "app/components/admin-addon", - "only": [ - "no-action" - ] - }, { "moduleId": "app/components/code-search", "only": [ @@ -50,18 +26,6 @@ module.exports = { "no-action" ] }, - { - "moduleId": "app/components/ember-version-compatibility", - "only": [ - "no-action" - ] - }, - { - "moduleId": "app/components/exclusive-button", - "only": [ - "no-action" - ] - }, { "moduleId": "app/components/large-search", "only": [ diff --git a/app/components/addon-note.hbs b/app/components/addon-note.hbs index bd130657..b46ffa5d 100644 --- a/app/components/addon-note.hbs +++ b/app/components/addon-note.hbs @@ -1,2 +1,4 @@ -Note - +
+ Note + +
diff --git a/app/components/addon-note.js b/app/components/addon-note.js deleted file mode 100644 index 9b9899fd..00000000 --- a/app/components/addon-note.js +++ /dev/null @@ -1,10 +0,0 @@ -import classic from 'ember-classic-decorator'; -import { classNames, tagName } from '@ember-decorators/component'; -import Component from '@ember/component'; - -@classic -@tagName('fieldset') -@classNames('note', 'test-addon-note') -export default class AddonNote extends Component { - content = ''; -} diff --git a/app/components/addon-review-form.hbs b/app/components/addon-review-form.hbs deleted file mode 100644 index 974e737b..00000000 --- a/app/components/addon-review-form.hbs +++ /dev/null @@ -1,17 +0,0 @@ -

Review this addon

-
-
-
    - {{#each this.questions as |question|}} -
  1. -
    {{question.text}}
    - -
  2. - {{/each}} -
-