Move FCP to index page and remove distinction between helping and input

Author: MinThaMie

app/app-styles/app.css

@@ -88,3 +88,18 @@
   }
 
 }
+
+.fcp-item {
+  display: block;
+  width: fit-content;
+  margin-bottom: var(--spacing-1);
+}
+
+.fcp-item h3 {
+  width: max-content;
+}
+
+.github-url {
+  position: absolute;
+  right: var(--spacing-5);
+}

app/routes/index.js

@@ -2,6 +2,9 @@ import Route from '@ember/routing/route';
 
 export default class IndexRoute extends Route {
   async model() {
-    return (await import('rfcs/README.md?raw')).default;
+    const result = (
+      await import('rfcs-app-toc-builder:fcp.json')
+    ).default;
+    return result;
   }
 }

app/routes/rfc.js

@@ -14,9 +14,12 @@ export default class RfcsRoute extends Route {
 
     const rfc = (await rfcs[rormalisedRFCId]()).default;
 
+    const number = Number(params.id.split('-')[0]);
+
     return {
       ...rfc,
       id: params.id,
+      url: `https://github.com/emberjs/rfcs/pull/${number}`,
     };
   }
 }

app/routes/rfcs-help.js

@@ -14,14 +14,6 @@ import EsSidebar from 'ember-styleguide/components/es-sidebar';
       <ul class="table-of-contents">
         <li class="toc-item">
           <LinkTo @route="index">Welcome</LinkTo>
-          <ul class="table-of-contents sub-table-of-contents">
-            <li class="toc-item">
-              <LinkTo @route="rfcs-input">RFCs that need your input</LinkTo>
-            </li>
-            <li class="toc-item">
-              <LinkTo @route="rfcs-help">RFCs that need your help</LinkTo>
-            </li>
-          </ul>
         </li>
 
         <li class="toc-heading">RFC process</li>

app/routes/rfcs-input.js

@@ -1,24 +1,21 @@
-import RfcCard from '../components/rfc-card';
+import { LinkTo } from '@ember/routing';
+
+function daysUntilFriday() {
+  let today = new Date().getDay();
+  return (12 - today)%7; //It's 12 because Friday is the fifth day, and we wan't to %7 so we added 7
+}
 
 <template>
   <div>
     <h1>Welcome to the Ember.js RFCs app</h1>
     <p>This is the place to find what is currently cooking within Ember.js.
       Check out the documentation on our RFC process and what RFCs need your
       input!</p>
-    <h2>RFC's that can use your input</h2>
-    <div class="rfc-grid">
-      <RfcCard @compact={{true}} @title="0127-make-sure-the-times-is-on-time" />
-      <RfcCard @compact={{true}} @title="0128-make-sure-the-times-is-on-time" />
-      <RfcCard @compact={{true}} @title="0129-make-sure-the-times-is-on-time" />
-    </div>
-    <a href="/rfcs-input">See all</a>
-    <h2>RFC's that need you help</h2>
-    <div class="rfc-grid">
-      <RfcCard @compact={{true}} @title="0117-make-sure-the-times-is-on-time" />
-      <RfcCard @compact={{true}} @title="0137-make-sure-the-times-is-on-time" />
-      <RfcCard @compact={{true}} @title="0147-make-sure-the-times-is-on-time" />
+    <h2>These RFCs are in their Final Comment Period and will move to their next stage in {{daysUntilFriday}} days</h2>
+    <div>
+      {{#each @model as |rfc|}}
+        <LinkTo class="fcp-item" @route="rfc" @model={{rfc.rfcFile}}>#{{rfc.number}} {{rfc.title}}</LinkTo>
+      {{/each}}
     </div>
-    <a href="/rfcs-help">See all</a>
   </div>
 </template>

app/templates/application.gjs

@@ -7,66 +7,12 @@ import { inject as controller } from '@ember/controller';
 export default class RFCRouteComponent extends Component {
   @controller application;
 
-  toggleSidebar() {
-    document.body.classList.toggle('sidebar-hidden');
-  }
 
   <template>
     {{pageTitle "Rfc"}}
     <div class="page">
-      <div class="menu-bar">
-        <div class="left-buttons">
-          {{!-- <button class="reset" type="button" {{on "click" this.toggleSidebar}}>
-          <FaIcon class="p2" @icon="bars" />
-        </button> --}}
-        </div>
-      </div>
-      <table class="rfc-data-table">
-        <thead>
-          <tr>
-            <td>Start Date</td>
-            <td>Release Date</td>
-            <td>Release Versions</td>
-            <td>PR link</td>
-            <td>Tracking Link</td>
-            <td>Stage</td>
-            <td>Teams</td>
-          </tr>
-        </thead>
-        <tbody>
-          <tr>
-            <td>{{formatDate @model.startDate}}</td>
-            <td>{{formatDate @model.releaseDate}}</td>
-            <td>
-              <ul>
-                {{#each-in @model.releaseVersions as |key value|}}
-                  <li>
-                    {{key}}:
-                    {{value}}
-                  </li>
-                {{/each-in}}
-              </ul>
-            </td>
-            <td>
-              {{#if @model.proposalPr}}
-                <a href={{@model.proposalPr}}>RFC Proposal Link</a>
-              {{/if}}
-            </td>
-            <td>
-              {{#if @model.trackingLink}}
-                <a href={{@model.trackingLink}}>Tracking Link</a>
-              {{/if}}
-            </td>
-            <td>{{@model.stage}}</td>
-            <td><ul>
-                {{#each @model.teams as |team|}}
-                  <li>{{team}}</li>
-                {{/each}}
-              </ul></td>
-          </tr>
-        </tbody>
-      </table>
       <div class="content">
+        <a class="github-url" href={{@model.url}} rel="noopener noreferrer" target="_blank">Open on Github</a>
         <MarkdownToHtml @markdown={{@model.content}} />
       </div>
     </div>