Skip to content

Pass selected options to onChange as first argument #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Pass selected options to onChange as first argument #40

wants to merge 2 commits into from

Conversation

@pankaj-awake
Copy link

@pankaj-awake pankaj-awake commented Oct 17, 2021

Fixes #30

@pankaj-awake
Copy link
Author

pankaj-awake commented Oct 17, 2021

The component needs more tests?
If yes, Please suggest some missing cases, sample PR, material (i have little experience writing tests).

Thanks

@pankaj-awake
Copy link
Author

pankaj-awake commented Oct 17, 2021

I wonder if the component should support an array @values if it is operating as multi select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pass the selected value(s) as the first parameter to @change

1 participant

@pankaj-awake