Skip to content

refactor: byte-compilation errors #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 7, 2025
Merged

refactor: byte-compilation errors #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7d033
refactor: require bibtex package in citar.el
arifer612 Nov 7, 2025
af6181a
refactor: remove quotation in ignore-error condition
arifer612 Nov 7, 2025
87cef90
refactor: sexp value-type for citar-display-transform-functions
arifer612 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion citar-file.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ SEPCHAR."
(goto-char (point-min))
(while (progn (skip-chars-forward skip) (not (eobp)))
(if (= ?\\ (following-char))
(ignore-error 'end-of-buffer (forward-char 2))
(ignore-error end-of-buffer (forward-char 2))
(push (delete-and-extract-region (point-min) (point)) strings)
(delete-char 1)))
(push (buffer-string) strings))
Expand Down
7 changes: 3 additions & 4 deletions citar.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
(require 'subr-x))
(require 'seq)
(require 'map)
(require 'bibtex)
(require 'browse-url)
(require 'citar-cache)
(require 'citar-format)
Expand Down Expand Up @@ -196,16 +197,14 @@ references as a string."

(defcustom citar-display-transform-functions
;; TODO change this name, as it might be confusing?
`((sn . (citar--shorten-names))
'((sn . (citar--shorten-names))
(etal . (citar--shorten-names 3 "&")))
"Configure transformation of field display values from raw values.

When the car symbol is associated with a field, run the cdr function
and optional arguments on the string value."
:group 'citar
:type '(alist :key-type symbol
;; REVIEW is this OK for now?
:value-type list))
:type '(alist :key-type symbol :value-type sexp))

;; Indicator defstruct

Expand Down
Loading