Skip to content

Commit 0d98191

Browse files
arifer612bdarcus
authored andcommitted
refactor: sexp value-type for citar-display-transform-functions
The value type for the custom variable `citar-display-transform-functions' is currently set to `list', which is not a proper elisp type. This will raise an error when attempting to byte-compile the file. Instead, the correct value-type should be sexp. Moreover, as there nothing is being evaluated, the backtick quotation should be replaced with a regular quotation to avoid unexpected expansion of the sexp.
1 parent 12fcf9b commit 0d98191

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

citar.el

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -197,16 +197,14 @@ references as a string."
197197

198198
(defcustom citar-display-transform-functions
199199
;; TODO change this name, as it might be confusing?
200-
`((sn . (citar--shorten-names))
200+
'((sn . (citar--shorten-names))
201201
(etal . (citar--shorten-names 3 "&")))
202202
"Configure transformation of field display values from raw values.
203203
204204
When the car symbol is associated with a field, run the cdr function
205205
and optional arguments on the string value."
206206
:group 'citar
207-
:type '(alist :key-type symbol
208-
;; REVIEW is this OK for now?
209-
:value-type list))
207+
:type '(alist :key-type symbol :value-type sexp))
210208

211209
;; Indicator defstruct
212210

0 commit comments

Comments
 (0)