fixup! feat: upgrading react-ssr-with-vite project dependencies

fpasquet · fpasquet · commit 16caae09dc3b · 2023-10-12T15:45:29.000+02:00
diff --git a/templates/react-ssr-with-vite/.github/dependabot.yml b/templates/react-ssr-with-vite/.github/dependabot.yml
@@ -0,0 +1,9 @@
+version: 2
+updates:
+  - package-ecosystem: "npm"
+    directory: "/"
+    schedule:
+      interval: "daily"
+    labels:
+      - "RFR"
+      - "dependencies"
diff --git a/templates/react-ssr-with-vite/.github/workflows/tests-and-checks.yml b/templates/react-ssr-with-vite/.github/workflows/tests-and-checks.yml
@@ -0,0 +1,33 @@
+name: Tests and Checks
+on:
+  pull_request:
+    paths:
+      - 'templates/react-ssr-with-vite/**'
+jobs:
+  checks:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v3
+      - name: Setup Node
+        uses: actions/setup-node@v3
+        with:
+          node-version: 18
+      - name: Get yarn cache directory path
+        id: yarn-cache-dir-path
+        run: echo "dir=$(yarn cache dir)" >> $GITHUB_OUTPUT
+      - uses: actions/cache@v3
+        id: yarn-cache
+        with:
+          path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
+          key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-yarn-
+      - name: Install modules
+        run: yarn --frozen-lockfile
+      - name: Run ESLint
+        run: yarn lint:es
+      - name: Run Compile TypeScript
+        run: yarn tsc
+      - name: Run Test
+        run: yarn test
diff --git a/templates/react-ssr-with-vite/.nvmrc b/templates/react-ssr-with-vite/.nvmrc
@@ -1 +1 @@
-v16
+v18
diff --git a/templates/react-ssr-with-vite/package.json b/templates/react-ssr-with-vite/package.json
@@ -18,7 +18,7 @@
   "engines": {
     "npm": "please-use-yarn-instead",
     "yarn": ">= 1.2.0",
-    "node": ">= 16.0"
+    "node": ">= 18.0"
   },
   "prettier": "@eleven-labs/prettier-config",
   "dependencies": {
@@ -41,7 +41,7 @@
     "@eleven-labs/prettier-config": "^1.0.0",
     "@types/express": "^4.17.19",
     "@types/i18next": "^13.0.0",
-    "@types/node": "^20.8.4",
+    "@types/node": "^18.18.4",
     "@types/react": "^18.2.28",
     "@types/react-dom": "^18.2.13",
     "@types/react-i18next": "^8.1.0",
@@ -54,7 +54,7 @@
     "prettier": "3.0.3",
     "sass": "^1.69.3",
     "ts-node": "^10.9.1",
-    "typescript": "^5.2.2",
+    "typescript": "^4.9.5",
     "vite": "^4.4.11",
     "vite-tsconfig-paths": "^4.2.1"
   }
diff --git a/templates/react-ssr-with-vite/src/constants.ts b/templates/react-ssr-with-vite/src/constants.ts
@@ -1,7 +1,11 @@
 import { getEnv } from '@/helpers/getEnvHelper';
 
-export const AUTHORIZED_LANGUAGES: string[] = ['fr', 'en'];
-export const DEFAULT_LANGUAGE: string = 'fr';
+export const LanguageEnum = {
+  EN: 'en',
+  FR: 'fr',
+};
+export const AUTHORIZED_LANGUAGES: string[] = Object.values(LanguageEnum);
+export const DEFAULT_LANGUAGE: string = LanguageEnum.FR;
 
 export const PATHS = {
   HOME: '/:lang/',
diff --git a/templates/react-ssr-with-vite/src/containers/LayoutTemplateContainer/LayoutTemplateContainer.tsx b/templates/react-ssr-with-vite/src/containers/LayoutTemplateContainer/LayoutTemplateContainer.tsx
@@ -3,7 +3,7 @@ import * as React from 'react';
 import { useTranslation } from 'react-i18next';
 import { Link, generatePath } from 'react-router-dom';
 
-import { PATHS } from '@/constants';
+import { LanguageEnum, PATHS } from '@/constants';
 import { getValidLanguage } from '@/helpers/langHelper';
 import { useCurrentPath } from '@/hooks/useCurrentPath';
 
@@ -14,7 +14,7 @@ export interface LayoutTemplateContainerProps {
 export const LayoutTemplateContainer: React.FC<LayoutTemplateContainerProps> = ({ children }) => {
   const { i18n, t } = useTranslation();
   const currentPath = useCurrentPath();
-  const languageForChange = i18n.language === 'fr' ? 'en' : 'fr';
+  const languageForChange = i18n.language === LanguageEnum.FR ? LanguageEnum.EN : LanguageEnum.FR;
 
   return (
     <Flex alignItems="center" flexDirection="column" gap="m" height="full" justifyContent="center">
@@ -38,8 +38,10 @@ export const LayoutTemplateContainer: React.FC<LayoutTemplateContainerProps> = (
         </Button>
       </Flex>
       <Button
+        to={generatePath(!currentPath || currentPath === PATHS.ROOT ? PATHS.HOME : currentPath, {
+          lang: languageForChange,
+        })}
         as={Link}
-        to={generatePath(currentPath === PATHS.ROOT ? PATHS.HOME : currentPath, { lang: languageForChange })}
         variant="secondary"
       >
         {t('layout.change-lang', { lang: languageForChange })}
diff --git a/templates/react-ssr-with-vite/src/pages/PokemonListPage/PokemonListPage.tsx b/templates/react-ssr-with-vite/src/pages/PokemonListPage/PokemonListPage.tsx
@@ -6,9 +6,9 @@ export interface PokemonListPageProps {
   title: string;
 }
 
-export const PokemonListPage: React.FC<PokemonListPageProps> = ({ pokemons }) => (
+export const PokemonListPage: React.FC<PokemonListPageProps> = ({ pokemons, title }) => (
   <>
-    <Heading>{<title />}</Heading>
+    <Heading>{title}</Heading>
     <Flex alignItems="center" gap="xs" justifyContent="center">
       {pokemons.map((pokemon, index) => (
         <Box key={index} textAlign="center">
diff --git a/templates/react-ssr-with-vite/yarn.lock b/templates/react-ssr-with-vite/yarn.lock
@@ -485,12 +485,10 @@
   resolved "https://registry.yarnpkg.com/@types/node/-/node-18.11.9.tgz#02d013de7058cea16d36168ef2fc653464cfbad4"
   integrity sha512-CRpX21/kGdzjOpFsZSkcrXMGIBWMGNIHXXBVFSH+ggkftxg+XYP20TESbh+zFvFj3EQOl5byk0HTRn1IL6hbqg==
 
-"@types/node@^20.8.4":
-  version "20.8.4"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-20.8.4.tgz#0e9ebb2ff29d5c3302fc84477d066fa7c6b441aa"
-  integrity sha512-ZVPnqU58giiCjSxjVUESDtdPk4QR5WQhhINbc9UBrKLU68MX5BF6kbQzTrkwbolyr0X8ChBpXfavr5mZFKZQ5A==
-  dependencies:
-    undici-types "~5.25.1"
+"@types/node@^18.18.4":
+  version "18.18.4"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-18.18.4.tgz#519fef47a13cf869be290c20fc6ae9b7fe887aa7"
+  integrity sha512-t3rNFBgJRugIhackit2mVcLfF6IRc0JE4oeizPQL8Zrm8n2WY/0wOdpOPhdtG0V9Q2TlW/axbF1MJ6z+Yj/kKQ==
 
 "@types/normalize-package-data@^2.4.0":
   version "2.4.2"
@@ -3909,10 +3907,10 @@ typed-array-length@^1.0.4:
     for-each "^0.3.3"
     is-typed-array "^1.1.9"
 
-typescript@^5.2.2:
-  version "5.2.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.2.2.tgz#5ebb5e5a5b75f085f22bc3f8460fba308310fa78"
-  integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==
+typescript@^4.9.5:
+  version "4.9.5"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a"
+  integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==
 
 unbox-primitive@^1.0.2:
   version "1.0.2"
@@ -3924,11 +3922,6 @@ unbox-primitive@^1.0.2:
     has-symbols "^1.0.3"
     which-boxed-primitive "^1.0.2"
 
-undici-types@~5.25.1:
-  version "5.25.3"
-  resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-5.25.3.tgz#e044115914c85f0bcbb229f346ab739f064998c3"
-  integrity sha512-Ga1jfYwRn7+cP9v8auvEXN1rX3sWqlayd4HP7OKk4mZWylEmu3KzXDUGrQUN6Ol7qo1gPvB2e5gX6udnyEPgdA==
-
 unpipe@1.0.0, unpipe@~1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/unpipe/-/unpipe-1.0.0.tgz#b2bf4ee8514aae6165b4817829d21b2ef49904ec"
