This repository was archived by the owner on Oct 1, 2020. It is now read-only.
Remove all CLI's from compile #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
approved these changes
Aug 27, 2017
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
This will need a major version bump.
malept
reviewed
Sep 17, 2017
| "rxjs": "^5.1.1", | ||
| "spawn-rx": "^2.0.3", | ||
| "yargs": "^4.8.1" | ||
| "spawn-rx": "^2.0.3" |
Member
There was a problem hiding this comment.
Looks like we can get rid of this too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With forge being pretty much the CLI for
electron-compileapplications packaging an internal CLI doesn't make much sense anymore.That and because
electron-compileis a production dependency we can remove theyargsdependency from production builds 👍Fixes #209.
NOTE: This is a breaking change so will be major bump (thanks for reminding me @malept )