Skip to content
This repository was archived by the owner on Oct 1, 2020. It is now read-only.
This repository was archived by the owner on Oct 1, 2020. It is now read-only.

File watching does not work correctly with Vim #193

@fvgs

Description

@fvgs

I'm using electron-compile via electron-forge. I believe the file watching for hot-module-replacement is not playing nicely with the backupcopy option in Vim. It fails to detect changes for subsequent writes after the first write to a file. I don't suppose this issue is unique to Vim, as other text editors offer similar features.

I tested out the solution in #190 which uses chokidar. The use of chokidar improves upon the current use of fs.watch() in that every write is now detected. However, the use of chokidar is not advisable. Upon removing the throttling (debouncing) as discussed in #190, I found chokidar, using Vim on macOS, produces multiple events for a single write. I also found keeping the throttling incurs a noticeable performance decrease in terms of the delay between writing to the file and seeing the changes in the application.

I am creating a PR to address the failure to detect file changes, multiple change events, and performance issues due to throttling, which should also address #189.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions