tests: fix and add more tests

Author: anders-elastisys

tests/unit/general/scripts-sbom.bats

@@ -2,9 +2,6 @@
 
 # bats file_tags=scripts-sbom
 
-sbom_backup=$(mktemp --suffix=-sbom.json)
-velero_chart_backup=$(mktemp --suffix=-velero-chart.json)
-
 setup() {
   load "../../bats.lib.bash"
   load_assert
@@ -14,16 +11,7 @@ setup() {
 
   export CK8S_AUTO_APPROVE=false
   export CK8S_SKIP_VALIDATION=false
-  VELERO_CHART_RELATIVE_FOLDER=helmfile.d/upstream/vmware-tanzu/velero
-  VELERO_CHART="${ROOT}/${VELERO_CHART_RELATIVE_FOLDER}/Chart.yaml"
-
-  cp "${ROOT}/docs/sbom.json" "${sbom_backup}"
-  cp "${VELERO_CHART}" "${velero_chart_backup}"
-}
-
-teardown() {
-  mv --force "${sbom_backup}" "${ROOT}/docs/sbom.json"
-  mv --force "${velero_chart_backup}" "${VELERO_CHART}"
+  VELERO_CHART_LOCATION=helmfile.d/upstream/vmware-tanzu/velero
 }
 
 @test "sbom script should show usage if no command is given" {
@@ -32,34 +20,45 @@ teardown() {
   assert_output --partial "COMMANDS:"
 }
 
-@test "sbom script get existing component" {
-  run sbom.bash get "${VELERO_CHART_RELATIVE_FOLDER}"
+@test "sbom script get existing component be successful" {
+  run sbom.bash get "${VELERO_CHART_LOCATION}"
   assert_success
   assert_output --partial '"name": "velero"'
 }
 
-@test "sbom script get non-existing component" {
+@test "sbom script get non-existing component should fail" {
   run sbom.bash get non-existing
   assert_failure
 }
 
+@test "sbom script get-charts should be successful" {
+  run sbom.bash get-charts
+  assert_success
+  assert_output --partial "${VELERO_CHART_LOCATION}"
+}
+
+@test "sbom script get-containers should be successful" {
+  run sbom.bash get-containers
+  assert_success
+}
+
 @test "sbom script validate should be successful" {
   run sbom.bash validate
   assert_success
   assert_output --partial 'BOM validated successfully.'
 }
 
-@test "sbom script add component with unsupported key" {
-  run sbom.bash add "${VELERO_CHART_RELATIVE_FOLDER}" unsupported-key "foo"
+@test "sbom script add component with unsupported key should fail" {
+  run sbom.bash add "${VELERO_CHART_LOCATION}" unsupported-key "foo"
   assert_failure
   assert_output --partial 'unsupported key'
 }
 
-@test "sbom script add component with supported key properties" {
-  export CK8S_AUTO_APPROVE=true
-  run sbom.bash add "${VELERO_CHART_RELATIVE_FOLDER}" properties "foo" "bar"
+@test "sbom script add component with supported key properties should prompt" {
+  run sbom.bash add "${VELERO_CHART_LOCATION}" properties "foo" "bar" <<<n
   assert_success
-  assert_output --partial 'Updated properties'
+  assert_output --partial 'BOM validated successfully.'
+  assert_output --partial 'Do you want to continue?'
 }
 
 @test "sbom script generate requires GITHUB_TOKEN" {
@@ -69,14 +68,19 @@ teardown() {
 }
 
 @test "sbom script update requires GITHUB_TOKEN" {
-  GITHUB_TOKEN="" run sbom.bash update "${VELERO_CHART_RELATIVE_FOLDER}"
+  GITHUB_TOKEN="" run sbom.bash update "${VELERO_CHART_LOCATION}"
   assert_failure
   assert_output --partial "Missing GITHUB_TOKEN"
 }
 
-@test "sbom script update with no change should work" {
-  export CK8S_SKIP_VALIDATION=true
-  GITHUB_TOKEN="test" run sbom.bash update "${VELERO_CHART_RELATIVE_FOLDER}"
+@test "sbom script update with no change should be successful" {
+  CK8S_SKIP_VALIDATION=true GITHUB_TOKEN="test" run sbom.bash update "${VELERO_CHART_LOCATION}"
   assert_success
   assert_output --partial "No change"
 }
+
+@test "sbom script diff with no change should be successful" {
+  CK8S_SKIP_VALIDATION=true GITHUB_TOKEN="test" run sbom.bash diff
+  assert_success
+  assert_output --partial "No chart changes found"
+}