bk: use explicit docker login (#5767) (#5785)

Author: mergify[bot]

.buildkite/pipeline.package.mbp.yml

@@ -15,6 +15,12 @@ common:
         lifetime: 10800 # seconds
         project-id: "elastic-observability-ci"
         project-number: "911195782929"
+  - dockerhub_login_plugin: &dockerhub_login_plugin
+      elastic/vault-docker-login#v0.6.0:
+        secret_path: 'kv/ci-shared/observability-github-secrets/shared/docker/dockerhub/observabilityrobots'
+  - docker_elastic_login_plugin: &docker_elastic_login_plugin
+      elastic/vault-docker-login#v0.6.0:
+        secret_path: 'kv/ci-shared/platform-ingest/elastic_docker_registry'
 
 steps:
   - label: "Package x86_64 snapshot"
@@ -45,6 +51,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *dockerhub_login_plugin
 
   - label: "Package FIPS x86_64 snapshot"
     if: "build.env('VERSION_QUALIFIER') == null"
@@ -60,6 +67,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
 
   - label: "Package FIPS x86_64 staging"
     key: "package-fips-x86-64-staging"
@@ -76,6 +84,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
 
   - label: "Package aarch64 snapshot"
     if: "build.env('VERSION_QUALIFIER') == null"
@@ -89,6 +98,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *dockerhub_login_plugin
 
   - label: "Package aarch64 staging"
     key: "package-arm-staging"
@@ -103,6 +113,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *dockerhub_login_plugin
 
   - label: "Package FIPS aarch64 snapshot"
     if: "build.env('VERSION_QUALIFIER') == null"
@@ -118,6 +129,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
 
   - label: "Package FIPS aarch64 staging"
     key: "package-fips-arm-staging"
@@ -134,6 +146,7 @@ steps:
       - build/distributions/**
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
 
   - label: "DRA snapshot"
     if: "${FILE_EXISTS_IN_REPO} && build.env('VERSION_QUALIFIER') == null"
@@ -145,6 +158,7 @@ steps:
       machineType: "c2-standard-16"
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
     depends_on:
       - step: "package-x86-64-snapshot"
         allow_failure: false
@@ -169,6 +183,7 @@ steps:
       machineType: "c2-standard-16"
     plugins:
       - *oidc_plugin
+      - *docker_elastic_login_plugin
     depends_on:
       - step: "package-x86-64-staging"
         allow_failure: false