Store.save raises if document id provided in _id field

[mariokostelac]

Store.save(document) with a document serializing _id field raises because ElasticSearch does not allow _id being serialized as part of the document body.

While investigating the fix, I've found interesting differences between update and save methods

• update uses __extract_id_from_document, which
  • treats id as _id for routing
  • removes _id and id from the document
  • does not store id outside of _id field
  • treats id as _id for routing
• save uses __get_id_from_document, which
  • treats id as _id for routing
  • does not remove _id or id from the document
  • tries to store id if it exists
  • makes the save call fail if document serializes _id.

Having this behaviour forces users to define :id field, instead of being able to define :_id only. Is this a bug or such behaviour is introduced on purpose?

If it's on purpose, I'd like to get some guidance on using :id and :_id field with this gem.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[mariokostelac]

This looks a bit aggressive closing policy to me given that there were no commits for 4 months. Is this repository still actively maintained?

[picandocodigo]

@mariokostelac sorry about that, the repository is still being maintained but other work has taken priority over it. That being said I am modifying stalebot's policy to be less aggressive and try to make some time in between other work to look at the issues here and hopefully releasing an update soon. We initially added it to see if some issues from years ago were still valid, so it doesn't need to be this aggressive right now. Thank you for your patience!

[mariokostelac]

@picandocodigo that makes perfect sense. Thanks for being transparent.