Update tests and fix issues

Author: ej2

CHANGELOG.rst

@@ -1,6 +1,13 @@
 Changelog
 =========
 
+* 0.9.11 (April 15, 2025)
+    * Add CostRate to TimeActivity
+    * Fix retrieval of Item SKU field
+    * Added support for attaching files using byte streams
+    * Default minor version to minimum supported version
+    * Fix incompatibility issues with setuptools
+
 * 0.9.11 (February 10, 2025)
     * Add warning for unsupported minorversion
     * Fix issue with new versions of jsonEncoder

quickbooks/client.py

@@ -242,15 +242,13 @@ def make_request(self, request_type, url, request_body=None, content_type='appli
     def get(self, *args, **kwargs):
         if 'params' not in kwargs:
             kwargs['params'] = {}
-        if 'minorversion' not in kwargs['params']:
-            kwargs['params']['minorversion'] = self.MINIMUM_MINOR_VERSION
+
         return self.make_request('GET', *args, **kwargs)
 
     def post(self, *args, **kwargs):
         if 'params' not in kwargs:
             kwargs['params'] = {}
-        if 'minorversion' not in kwargs['params']:
-            kwargs['params']['minorversion'] = self.MINIMUM_MINOR_VERSION
+
         return self.make_request('POST', *args, **kwargs)
 
     def process_request(self, request_type, url, headers="", params="", data=""):

quickbooks/objects/employee.py

@@ -17,7 +17,7 @@ class Employee(QuickbooksManagedObject, QuickbooksTransactionEntity):
 
     def __init__(self):
         super(Employee, self).__init__()
-        self.SSN = ""
+        self.SSN = None
 
         self.GivenName = ""
         self.FamilyName = ""
@@ -29,9 +29,9 @@ def __init__(self):
         self.Title = ""
         self.BillRate = 0
         self.CostRate = 0
-        self.BirthDate = ""
+        self.BirthDate = None
         self.Gender = None
-        self.HiredDate = ""
+        self.HiredDate = None
         self.ReleasedDate = ""
         self.Active = True
         self.Organization = False

tests/integration/test_account.py

@@ -24,7 +24,7 @@ def test_create(self):
         account.AccountSubType = "CashOnHand"
 
         created_account = account.save(qb=self.qb_client)
-        
+
         # Verify the save was successful
         self.assertIsNotNone(created_account)
         self.assertIsNotNone(created_account.Id)

tests/integration/test_base.py

@@ -20,6 +20,7 @@ def setUp(self):
             auth_client=self.auth_client,
             refresh_token=os.environ.get('REFRESH_TOKEN'),
             company_id=os.environ.get('COMPANY_ID'),
+            minorversion=75
         )
 
         self.qb_client.sandbox = True
@@ -40,6 +41,7 @@ def setUp(self):
             # auth_client=self.auth_client,
             refresh_token='REFRESH_TOKEN',
             company_id='COMPANY_ID',
+            minorversion=75
         )
 
         self.qb_client.sandbox = True

tests/integration/test_employee.py

@@ -1,15 +1,17 @@
-from datetime import datetime
+from datetime import datetime, date
 
 from quickbooks.objects.base import Address, PhoneNumber
 from quickbooks.objects.employee import Employee
 from tests.integration.test_base import QuickbooksTestCase
+from quickbooks.helpers import qb_date_format
 
 
 class EmployeeTest(QuickbooksTestCase):
     def test_create(self):
         employee = Employee()
-        employee.SSN = "444-55-6666"
+        employee.SSN = None
         employee.GivenName = "John"
+        employee.HiredDate = qb_date_format(date(2020, 7, 22))
         employee.FamilyName = "Smith {0}".format(datetime.now().strftime('%d%H%M%S'))
 
         employee.PrimaryAddr = Address()
@@ -19,13 +21,13 @@ def test_create(self):
         employee.PrimaryAddr.PostalCode = "93242"
 
         employee.PrimaryPhone = PhoneNumber()
-        employee.PrimaryPhone.FreeFormNumber = "408-525-1234"
+        employee.PrimaryPhone.FreeFormNumber = "4085251234"
+
         employee.save(qb=self.qb_client)
 
         query_employee = Employee.get(employee.Id, qb=self.qb_client)
 
         self.assertEqual(query_employee.Id, employee.Id)
-        self.assertEqual(query_employee.SSN, "XXX-XX-XXXX")
         self.assertEqual(query_employee.GivenName, employee.GivenName)
         self.assertEqual(query_employee.FamilyName, employee.FamilyName)
         self.assertEqual(query_employee.PrimaryAddr.Line1, employee.PrimaryAddr.Line1)

tests/unit/test_client.py

@@ -123,7 +123,7 @@ def test_update_object_with_request_id(self, make_req):
         qb_client.update_object("Customer", "request_body", request_id="123")
 
         url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/customer"
-        make_req.assert_called_with("POST", url, "request_body", file_path=None, file_bytes=None, request_id="123", params={'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
+        make_req.assert_called_with("POST", url, "request_body", file_path=None, file_bytes=None, request_id="123", params={})
 
     @patch('quickbooks.client.QuickBooks.get')
     def test_get_current_user(self, get):
@@ -141,7 +141,7 @@ def test_get_report(self, make_req):
 
         qb_client.get_report("profitandloss", {1: 2})
         url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/reports/profitandloss"
-        expected_params = {1: 2, 'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION}
+        expected_params = {1: 2}
         make_req.assert_called_with("GET", url, params=expected_params)
 
     @patch('quickbooks.client.QuickBooks.make_request')
@@ -151,7 +151,7 @@ def test_get_single_object(self, make_req):
 
         qb_client.get_single_object("test", 1)
         url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/test/1"
-        make_req.assert_called_with("GET", url, {}, params={'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
+        make_req.assert_called_with("GET", url, {}, params={})
 
     @patch('quickbooks.client.QuickBooks.make_request')
     def test_get_single_object_with_params(self, make_req):
@@ -160,7 +160,7 @@ def test_get_single_object_with_params(self, make_req):
 
         qb_client.get_single_object("test", 1, params={'param':'value'})
         url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/test/1"
-        make_req.assert_called_with("GET", url, {}, params={'param':'value', 'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
+        make_req.assert_called_with("GET", url, {}, params={'param':'value'})
 
     @patch('quickbooks.client.QuickBooks.process_request')
     def test_make_request(self, process_request):