chore: edm4hep-0.99.4 #79
Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the edm4hep package from v0.99.1 to v0.99.4 by cherry-picking two commits from the upstream spack/spack-packages repository. The upgrade brings in deprecation removals and adds latest tags with updated dependencies for the edm4hep event data model framework.
Key Changes:
- Cherry-picked two upstream spack commits for edm4hep updates
- Updated edm4hep version requirement from @0.99.1 to @0.99.4
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spack-packages.sh | Added two cherry-pick commit hashes (9cf8ee9 and 78a6c5f) with file mappings and descriptions for edm4hep deprecation removals and version updates |
| spack-environment/packages.yaml | Updated edm4hep version constraint from @0.99.1 to @0.99.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
edm4hep-0.99.4
branch
2 times, most recently
from
e08a76c to
a6fa239
Compare
wdconinc
force-pushed
the
edm4hep-0.99.4
branch
from
a6fa239 to
4e8eccf
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
spack-packages.sh:48
- The cherry-pick hash
438a7d95de1b81e15107edbf341b20824ec80635(for "root: add v6.36.06") was removed from the list, but its corresponding description comment at line 105## 438a7d95de1b81e15107edbf341b20824ec80635: root: add v6.36.06is still present in the file. For consistency, when removing a cherry-pick hash, its description comment should also be removed.
c75e10845431600b163c597545bd099e427c62f5
438a7d95de1b81e15107edbf341b20824ec80635
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
edm4hep-0.99.4
branch
from
4e8eccf to
b383b5e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wdconinc
force-pushed
the
edm4hep-0.99.4
branch
from
16cb8a5 to
b68b37d
Compare
wdconinc
force-pushed
the
edm4hep-0.99.4
branch
from
b68b37d to
c0a9a23
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Briefly, what does this PR introduce?
This PR upgrades
edm4hepto v0.99.4 (diff).Needs: