Fix #849 Use inputs instead of menu for checked state (#850)

Filter the cached labels to exclude the search input.

Author: Michael

docs/js/widget.min.js

@@ -103,7 +103,7 @@
         $element.on('multiselectbeforeclose', $.proxy(this._reset, this));
       }        
 
-      var $label = $(document.createElement('label')).text(opts.label).append(this.$input);
+      var $label = $(document.createElement('label')).text(opts.label).append(this.$input).addClass('ui-multiselect-filter-label');
       this.$wrapper = $(document.createElement('div'))
                                 .addClass(filterClass)
                                 .append($label)

src/jquery.multiselect.filter.js

@@ -591,7 +591,7 @@
       this.$checkboxes = this.$menu.children('.ui-multiselect-checkboxes');
 
       // Update saved labels and inputs
-      this.$labels = this.$menu.find('label');
+      this.$labels = this.$menu.find('label:not(.ui-multiselect-filter-label)');
       this.$inputs = this.$labels.children('input');
 
       // If the filter widget is in use, then also update its cache.
@@ -1652,15 +1652,15 @@
      * @returns {array} list of inputs
      */
     getChecked: function() {
-      return this.$menu.find('input:checked');
+      return this.$inputs.filter(":checked");
     },
 
     /**
      * Provides a list of all options that are not checked
      * @returns {array} list of inputs
      */
     getUnchecked: function() {
-      return this.$menu.find('input:not(:checked)');
+      return this.$inputs.filter(":not(:checked)");
     },
 
     /**

src/jquery.multiselect.js

@@ -64,6 +64,16 @@
     assert.ok( input.is(":visible"), "Filter input box is visible" );
   });
 
+  QUnit.test("checked and unchecked", function(assert) {
+    var labelCount = el.multiselect("getLabels").length
+    var uncheckedCount = el.multiselect("getUnchecked").length
+    var checkedCount = el.multiselect("getChecked").length
+    assert.equal(uncheckedCount, labelCount, "Only the ten options are returned");
+    assert.equal(uncheckedCount + checkedCount, labelCount, "Unchecked + checked should equal total inputs")
+    el.multiselect("refresh");
+    assert.equal(el.multiselect("getUnchecked").length, uncheckedCount, "Search input still excluded after refresh")
+  });
+
   QUnit.test("filtering by node text", function(assert){
     searchTest( "bbaa", 2);
     searchTest( "bbaarr", 1);