MvdScopeTransformer question

[thomasrutger]

I noticed that the MvdScopeTransformer is very similar to the default EdcScopeToCriterionTransformer, with the exception of the list of knownCredentialTypes. In particular, if a scope string is not recognized as a "known credential" it returns the Criterion

"verifiableCredential.credential.credentialSubject.claims.level"=credentialType

The purpose of this fallback behavior is unclear to me. Does this relate to an MVD-specific scope alias, or is there another reason behind it? Why not return a failure if the scope is unrecognized?

[paullatzelsperger]

this may be an artifact of dark times past, and could probably be removed. have you tried simply removing it?

[thomasrutger]

Replacing it with returning a failure if a scope is not recognized works just fine. Should I go ahead and contribute this?

[paullatzelsperger]

sure, go ahead. I'll create an issue, so be sure to link your PR to it: #383