From 69d838397b527156d89b2f3f077aae18fad3f20c Mon Sep 17 00:00:00 2001 From: Wang Shenwei Date: Sun, 12 Jan 2025 20:53:35 +0800 Subject: [PATCH] fix(): use all local bricks if localBricks is unset --- packages/brick-container/serve/getProxy.js | 4 ++-- .../brick-container/serve/utils/getProcessedPublicDeps.js | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/brick-container/serve/getProxy.js b/packages/brick-container/serve/getProxy.js index a6209d8ef8..5be9c3b9e0 100644 --- a/packages/brick-container/serve/getProxy.js +++ b/packages/brick-container/serve/getProxy.js @@ -290,7 +290,7 @@ export default function getProxy(env, getRawIndexHtml) { /\bw\.PUBLIC_DEPS\s*=\s*(\[[^;]*\])\s*;/ )?.[1]; - if (publicDeps && localBricks?.length) { + if (publicDeps) { publicDeps = getProcessedPublicDeps( publicDeps, localBricks @@ -382,7 +382,7 @@ export default function getProxy(env, getRawIndexHtml) { /\bw\.PUBLIC_DEPS\s*=\s*(\[[^;]*\])\s*;/ )?.[1]; - if (publicDeps && localBricks?.length) { + if (publicDeps) { htmlContent = htmlContent.replace( /\bw\.PUBLIC_DEPS\s*=\s*\[[^;]*\]\s*;/, `w.PUBLIC_DEPS=${getProcessedPublicDeps( diff --git a/packages/brick-container/serve/utils/getProcessedPublicDeps.js b/packages/brick-container/serve/utils/getProcessedPublicDeps.js index a8f6715655..aa1fb22947 100644 --- a/packages/brick-container/serve/utils/getProcessedPublicDeps.js +++ b/packages/brick-container/serve/utils/getProcessedPublicDeps.js @@ -1,7 +1,9 @@ export function getProcessedPublicDeps(publicDepsStr, localBrickPackages) { try { const parsedPublicDeps = JSON.parse(publicDepsStr).filter( - (item) => !localBrickPackages.includes(item.filePath.split("/")[1]) + (item) => + localBrickPackages && + !localBrickPackages.includes(item.filePath.split("/")[1]) ); return JSON.stringify(parsedPublicDeps);