Merge pull request #5006 from easybuilders/5.1.x

release EasyBuild v5.1.2

Author: boegel

.github/workflows/unit_tests.yml

@@ -13,7 +13,7 @@ jobs:
   setup:
     runs-on: ubuntu-latest
     outputs:
-        lmod8: Lmod-8.7.58
+        lmod8: Lmod-8.7.65
         modules4: modules-4.5.3
         modules5: modules-5.3.1
     steps:

RELEASE_NOTES

@@ -4,6 +4,45 @@ For more detailed information, please see the git log.
 These release notes can also be consulted at https://docs.easybuild.io/release-notes .
 
 
+v5.1.2 (26 Sept 2025)
+---------------------
+
+update/bugfix release
+
+- enhancements:
+  - show readable error message when applying patch without (extracted) source (#4738)
+  - add support for `amdgcn-capabilities` configuration option and `amdgcn_capabilities` easyconfig parameter + related templates, similar to `cuda-compute-capabilities` (#4860)
+  - try to empty install dir if removing it fails (#4932)
+  - add support for "extensions" on Tcl modulefiles , but disable it for now (#4972, #4978, #4985)
+  - exit with appropriate error code for `--search` when no match is found (#4976)
+  - handle `post_install_patches` and `post_install_msgs` for extensions (#4980)
+  - skip RPATH sanity check for symlinks explicitely (#4988)
+  - take `--terse` into account for `--dry-run-short`/`-D` and `--dry-run` (#4989)
+- bug fixes:
+  - test if all extensions support parallel install before attempting parallel extension install (#4949)
+  - do not fail for read-only installation directory on `--module-only` (re)builds (#4958, #5004)
+  - store all patches (incl. the ones for extensions) that need to be copied to a repo/reprod dir in an `all_patches` set (#4960)
+  - fix error when adding files to existing PR with `--update-pr` and refactor + fixes in `options` tests (#4962)
+  - add back `OrderedDict` import in (deprecated) `easybuild.tools.py2vs3.py3` module (#4965)
+  - fixes for RPATH wrapper script:
+    - detect & replace `-Xlinker --enable-new-dtags` (#4970)
+    - do not add RPATH (linking) flags when `-c` flag specified (#4981)
+  - honor `--disable-module-extensions` configuration option (#4971)
+  - fix f-string in rpath check and skip check for linked libs on symlinks (#4975)
+  - fix passing command as list of strings to `run_shell_cmd` (#4977)
+  - add `f` for the f-string in a `git_config` error (#4982)
+  - keep `ModuleTool.mod_paths` in sync with `MODULEPATH` in `ModuleTool.load()` (#4991)
+  - fix failure to resolve template in tests (#4994)
+  - update regex used in `Lmod.get_setenv_value_from_modulefile` (#4998)
+- enhancements and fixes for test suite:
+  - only run tests for `--from-commit` for subset of test configurations (those for which a GitHub token is available) (#4967)
+  - adapt `module_extensions` disable test for Tcl modulefiles (#4973)
+- other changes:
+  - don't log variables (un)set + raw output of `module` command when cleaning up fake module (#4942)
+  - introduce `PYTHON_EXE` variable in template for RPATH wrapper script (to easily replace name of `python` command to use in `buildenv` easyblock) (#4984)
+  - remove deprecated license classifier in `setup.py` (#5002)
+
+
 v5.1.1 (6 July 2025)
 --------------------
 

easybuild/base/frozendict.py

@@ -52,7 +52,7 @@ def __repr__(self):
 
     def __hash__(self):
         if self.__hash is None:
-            self.__hash = reduce(operator.xor, map(hash, self.iteritems()), 0)
+            self.__hash = reduce(operator.xor, map(hash, self.items()), 0)
 
         return self.__hash
 

easybuild/base/testing.py

@@ -114,13 +114,13 @@ def assertEqual(self, a, b, msg=None):
             raise AssertionError("%s:\nDIFF%s:\n%s" % (msg, limit, ''.join(diff[:self.ASSERT_MAX_DIFF]))) from None
 
     def assertExists(self, path, msg=None):
-        """Assert the given path exists"""
+        """Assert that the given path exists"""
         if msg is None:
             msg = "'%s' should exist" % path
         self.assertTrue(os.path.exists(path), msg)
 
     def assertNotExists(self, path, msg=None):
-        """Assert the given path exists"""
+        """Assert that the given path does not exist"""
         if msg is None:
             msg = "'%s' should not exist" % path
         self.assertFalse(os.path.exists(path), msg)

easybuild/framework/easyblock.py

@@ -84,6 +84,7 @@
     'toolchainopts': [None, 'Extra options for compilers', TOOLCHAIN],
 
     # BUILD easyconfig parameters
+    'amdgcn_capabilities': [[], "List of AMDGCN capabilities to build with (if supported)", BUILD],
     'banned_linked_shared_libs': [[], "List of shared libraries (names, file names, or paths) which are not allowed "
                                       "to be linked in any installed binary/library", BUILD],
     'bitbucket_account': ['%(namelower)s', "Bitbucket account name to be used to resolve template values in source"

easybuild/framework/easyconfig/default.py

@@ -1992,6 +1992,28 @@ def get_cuda_cc_template_value(self, key, required=True):
             error_msg = "%s is not a template value based on --cuda-compute-capabilities/cuda_compute_capabilities"
             raise EasyBuildError(error_msg, key)
 
+    def get_amdgcn_cc_template_value(self, key, required=True):
+        """
+        Get template value based on --amdgcn-capabilities EasyBuild configuration option
+        and amdgcn_capabilities easyconfig parameter.
+        Returns user-friendly error message in case neither are defined,
+        or if an unknown key is used.
+        """
+        if key.startswith('amdgcn_') and any(x == key for x in TEMPLATE_NAMES_DYNAMIC):
+            try:
+                return self.template_values[key]
+            except KeyError:
+                if not required:
+                    self.log.debug(f'Key {key} not found in template values, returning empty value')
+                    return ''
+                error_msg = "Template value '%s' is not defined!\n"
+                error_msg += "Make sure that either the --amdgcn-capabilities EasyBuild configuration "
+                error_msg += "option is set, or that the amdgcn_capabilities easyconfig parameter is defined."
+                raise EasyBuildError(error_msg, key)
+        else:
+            error_msg = "%s is not a template value based on --amdgcn-capabilities/amdgcn_capabilities"
+            raise EasyBuildError(error_msg, key)
+
 
 def det_installversion(version, toolchain_name, toolchain_version, prefix, suffix):
     """Deprecated 'det_installversion' function, to determine exact install version, based on supplied parameters."""

easybuild/framework/easyconfig/easyconfig.py

@@ -88,6 +88,11 @@
 # template values which are only generated dynamically
 TEMPLATE_NAMES_DYNAMIC = {
     'arch': 'System architecture (e.g. x86_64, aarch64, ppc64le, ...)',
+    'amdgcn_capabilities': "Comma-separated list of AMDGCN capabilities, as specified via "
+                           "--amdgcn-capabilities configuration option or "
+                           "via amdgcn_capabilities easyconfig parameter",
+    'amdgcn_cc_space_sep': "Space-separated list of AMDGCN capabilities",
+    'amdgcn_cc_semicolon_sep': "Semicolon-separated list of AMDGCN capabilities",
     'cuda_compute_capabilities': "Comma-separated list of CUDA compute capabilities, as specified via "
                                  "--cuda-compute-capabilities configuration option or "
                                  "via cuda_compute_capabilities easyconfig parameter",
@@ -478,6 +483,14 @@ def template_constant_dict(config, ignore=None, toolchain=None):
         template_values['cuda_sm_comma_sep'] = ','.join(sm_values)
         template_values['cuda_sm_space_sep'] = ' '.join(sm_values)
 
+    # step 7. AMDGCN capabilities
+    #         Use the commandline / easybuild config option if given, else use the value from the EC (as a default)
+    amdgcn_cc = build_option('amdgcn_capabilities') or config.get('amdgcn_capabilities')
+    if amdgcn_cc:
+        template_values['amdgcn_capabilities'] = ','.join(amdgcn_cc)
+        template_values['amdgcn_cc_space_sep'] = ' '.join(amdgcn_cc)
+        template_values['amdgcn_cc_semicolon_sep'] = ';'.join(amdgcn_cc)
+
     unknown_names = []
     for key in template_values:
         if not (key in common_template_names or key in TEMPLATE_NAMES_DYNAMIC):

easybuild/framework/easyconfig/templates.py

@@ -232,6 +232,8 @@ def post_install_extension(self):
         Stuff to do after installing a extension.
         """
         self.master.run_post_install_commands(commands=self.cfg.get('postinstallcmds', []))
+        self.master.apply_post_install_patches(patches=[p for p in self.patches if p['postinstall']])
+        self.master.print_post_install_messages(msgs=self.cfg.get('postinstallmsgs', []))
 
     def install_extension_substep(self, substep, *args, **kwargs):
         """

easybuild/framework/extension.py

@@ -49,6 +49,7 @@
 # IMPORTANT this has to be the first easybuild import as it customises the logging
 #  expect missing log output when this not the case!
 from easybuild.tools.build_log import EasyBuildError, print_error, print_msg, print_warning, stop_logging
+from easybuild.tools.build_log import EasyBuildExit
 
 from easybuild.framework.easyblock import build_and_install_one, inject_checksums, inject_checksums_to_json
 from easybuild.framework.easyconfig import EASYCONFIGS_PKG_SUBDIR
@@ -243,10 +244,10 @@ def run_contrib_style_checks(ecs, check_contrib, check_style):
     return check_contrib or check_style
 
 
-def clean_exit(logfile, tmpdir, testing, silent=False):
+def clean_exit(logfile, tmpdir, testing, silent=False, exit_code=0):
     """Small utility function to perform a clean exit."""
     cleanup(logfile, tmpdir, testing, silent=silent)
-    sys.exit(0)
+    sys.exit(exit_code)
 
 
 def process_easystack(easystack_path, args, logfile, testing, init_session_state, do_build):
@@ -675,15 +676,13 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr
     else:
         _log.debug("Packaging not enabled, so not checking for packaging support.")
 
-    # search for easyconfigs, if a query is specified
-    if search_query:
-        search_easyconfigs(search_query, short=options.search_short, filename_only=options.search_filename,
-                           terse=options.terse)
-
     if options.check_eb_deps:
         print_checks(check_easybuild_deps(modtool))
 
-    # GitHub options that warrant a silent cleanup & exit
+    # Exitcode to use when exiting directly after any of the following options
+    silent_exit_code = EasyBuildExit.SUCCESS
+
+    # Options that warrant a silent cleanup & exit
     if options.check_github:
         check_github()
 
@@ -713,6 +712,11 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr
     elif options.list_software:
         print(list_software(output_format=options.output_format, detailed=options.list_software == 'detailed'))
 
+    elif search_query:
+        if not search_easyconfigs(search_query, short=options.search_short, filename_only=options.search_filename,
+                                  terse=options.terse):
+            silent_exit_code = EasyBuildExit.MISSING_EASYCONFIG
+
     elif options.create_index:
         print_msg("Creating index for %s..." % options.create_index, prefix=False)
         index_fp = dump_index(options.create_index, max_age_sec=options.index_max_age)
@@ -732,13 +736,13 @@ def main(args=None, logfile=None, do_build=None, testing=False, modtool=None, pr
         options.list_prs,
         options.merge_pr,
         options.review_pr,
-        # --missing-modules is processed by process_eb_args,
+        # --missing-modules and dry_run(_short) are processed by process_eb_args,
         # so we can't exit just yet here if it's used in combination with --terse
-        options.terse and not options.missing_modules,
+        options.terse and not (options.missing_modules or options.dry_run or options.dry_run_short),
         search_query,
     ]
     if any(early_stop_options):
-        clean_exit(logfile, eb_tmpdir, testing, silent=True)
+        clean_exit(logfile, eb_tmpdir, testing, silent=True, exit_code=silent_exit_code)
 
     # update session state
     eb_config = eb_go.generate_cmd_line(add_default=True)