From 754eb0f5564fd3081411f48de531d80d4f8d1199 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 12 Oct 2022 22:47:52 +0000 Subject: [PATCH] Adding tarfile member sanitization to extractall() --- MinIO TensorFlow.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/MinIO TensorFlow.py b/MinIO TensorFlow.py index 5b9098c..616d157 100644 --- a/MinIO TensorFlow.py +++ b/MinIO TensorFlow.py @@ -39,7 +39,26 @@ extract_folder = f"/tmp/{datasets_bucket}/" with tarfile.open("/tmp/dataset.tar.gz", "r:gz") as tar: - tar.extractall(path=extract_folder) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, path=extract_folder) # Pre-Processing