Skip to content

Commit b17b647

Browse files
authored
Merge pull request #83 from Tmonster/fix_endpoint_for_s3
Include region in s3 endpoints
2 parents 9497e1b + f359dca commit b17b647

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

extension/httpfs/s3fs.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,10 @@ S3AuthParams S3AuthParams::ReadFrom(optional_ptr<FileOpener> opener, FileOpenerI
196196
}
197197
}
198198

199-
if (result.endpoint.empty()) {
200-
result.endpoint = "s3.amazonaws.com";
199+
if (!result.region.empty() && (result.endpoint.empty() || result.endpoint == "s3.amazonaws.com")) {
200+
result.endpoint = StringUtil::Format("s3.%s.amazonaws.com", result.region);
201+
} else if (result.endpoint.empty()) {
202+
result.endpoint = "s3.amazonaws.com";
201203
}
202204

203205
return result;

0 commit comments

Comments
 (0)