Fixed "Value cannot be null. (Parameter 'args')"

icnocop · mconnew · commit 5ad1da5b788c · 2025-05-21T13:29:28.000-07:00
Fixes #5452
diff --git a/src/dotnet-svcutil/lib/src/FrameworkFork/Microsoft.Xml/Xml/schema/XmlSchemaException.cs b/src/dotnet-svcutil/lib/src/FrameworkFork/Microsoft.Xml/Xml/schema/XmlSchemaException.cs
@@ -99,14 +99,12 @@ internal XmlSchemaException(string res, string[] args, Exception innerException,
 
         internal static string CreateMessage(string res, string[] args)
         {
-            try
+            if (args == null)
             {
-                return string.Format(res, args);
-            }
-            catch (MissingManifestResourceException)
-            {
-                return "UNKNOWN(" + res + ")";
+                return res;
             }
+
+            return string.Format(res, args);
         }
 
         internal string GetRes

Original file line number	Diff line number	Diff line change
`@@ -99,14 +99,12 @@ internal XmlSchemaException(string res, string[] args, Exception innerException,`
`99`	`99`
`100`	`100`	`internal static string CreateMessage(string res, string[] args)`
`101`	`101`	`{`
`102`		`- try`
	`102`	`+ if (args == null)`
`103`	`103`	`{`
`104`		`- return string.Format(res, args);`
`105`		`- }`
`106`		`- catch (MissingManifestResourceException)`
`107`		`- {`
`108`		`- return "UNKNOWN(" + res + ")";`
	`104`	`+ return res;`
`109`	`105`	`}`
	`106`	`+`
	`107`	`+ return string.Format(res, args);`
`110`	`108`	`}`
`111`	`109`
`112`	`110`	`internal string GetRes`