Skip to content

Stop producing the git-info files #4858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
premun opened this issue May 21, 2025 · 2 comments · Fixed by #4866
Open

Stop producing the git-info files #4858

premun opened this issue May 21, 2025 · 2 comments · Fixed by #4866
Assignees

Comments

@premun
Copy link
Member

premun commented May 21, 2025

Context

Similarly to #2428, we can stop producing the git-info files as they are no longer needed.

We should still make sure that the servicing branches can use new darc and produce these files.
Though the 8.0 branches might be stuck on an older version of darc already.
The 9.0 branches recently got updated: https://dev.azure.com/dnceng/internal/_git/dotnet-sdk/pullrequest/50250
So we might need to keep the support because of these.
Maybe it could produce these when the folder/file exists and ignore it if it doesn't,

Goal

Make darc not update the git-info files when they don't exist.

@ViktorHofer
Copy link
Member

Maybe it could produce these when the folder/file exists and ignore it if it doesn't,

Yes, I think that's the best tactical solution. Same could apply to #2428. If the entry exists, update it. If not, don't update it.

@premun
Copy link
Member Author

premun commented May 28, 2025

Oh no, the git-info came back because the commit the ff branch is based on an older commit which still has these files..

@premun premun moved this from Ready to Blocked in .NET Unified Build May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging a pull request may close this issue.

2 participants