Disabling client GUID creation

[mashlol]

In 0a06c19 the ability for clients to set their own GUID was added.

1. Why? I don't see what use-case there would be for a client to tell the server how to refer to itself.
2. Is there a way to disable it?

This is causing me an issue because Guid.NewGuid appears to return all zeroes on my iOS build (still working out why).

It seems to me the default behavior should be for the server to assign each client an identifier, and have some setting to change this default if it is desired to allow clients to set their own identifiers.

[jchristn]

Having this capability allows the developer to use well-known/user-defined GUIDs for specific endpoints, persistent across reconnections.

[mashlol]

Thanks for the response!

Wouldn't that be a security concern? If the "special" GUID leaked, anyone could impersonate that endpoint/client, which then makes the GUID a secret that needs to be managed.

It feels like a feature that's out of scope for a TCP library to me, but I'm not super familiar if other libraries have similar functionality at this layer. Regardless, it feels to me like it shouldn't be the default as it seems like a potential footgun.