Skip to content

IE Support Integration #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue Aug 3, 2015 · 2 comments
Closed

IE Support Integration #1

ghost opened this issue Aug 3, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 3, 2015

Hi @derrybarry ,

Since this repo is significantly different from that of Shopify/dashing, what would it take to integrate the Internet Explorer fixes found here and here into this project?

There are files and directories found in the Dashing repo that do not exist in this project:

Affected Files:

Directories:

  • lib/dashing/*
  • templates/project/*

Any help is appreciated, thank you.

Disclaimer: I do not use Internet Explorer, but there are some within my company that do. As such, it's my obligation to make sure they can view the dashboard using their browser of choice.

@derrybarry
Copy link
Owner

Have you tested the IE fixes in a base dashing install? I would do that before testing any further, from what i can see the changes mentions in #310 are to the main dashing framework, my repo is just a set of dashboards which are on a level above.

In short my advice for supporting IE would be build a base Dashing install, get that working with the changes from @LiquidCC and then test if my repo works on that install first before going on to test on different browsers.

@derrybarry
Copy link
Owner

Closing Issue as it is related to the main dashing framework, not just this dashboard in particular

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant