Make Container, DerivedContainer & Pod inherit from ParameterSet

[dcermak]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.77%. Comparing base (a465c0f) to head (1336897).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   96.36%   96.77%   +0.40%     
==========================================
  Files           9        9              
  Lines        1101     1178      +77     
  Branches      164      168       +4     
==========================================
+ Hits         1061     1140      +79     
+ Misses         25       23       -2     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[dmpop]

You are now handling (...) instance, and have to unpack them?

[dcermak]

the issue is this: let's say you are creating a TW container image:

TW = Container(url="registry.opensuse.org/opensuse/tumbleweed")

and now you want to wrap it in a pytest.param(), then you'd usually do this:

TW = pytest.param(
    Container(url="registry.opensuse.org/opensuse/tumbleweed"),
    marks=[pytest.mark.tumbleweed],
)

But now the TW object is no longer an instance of the Container class. If you now want to get any attribute, you have to call:

TW.values[0].url

The whole point of this gynormous PR is, that Container is a ParameterSet itself, and you directly get TW.url, but it behaves like a ParameterSet as well

[dmpop]

Suggested change

	2. :py:class:`~pytest_container.container.DerivedContainer` do not "inherit" the
	marks from their base containers. This has proven to be a very annoying
	limitation in practice.
	2. :py:class:`~pytest_container.container.DerivedContainer` does not "inherit" the
	marks from their base containers. This has proven to be a very annoying
	limitation in practice.

"inherit"

Why is inherit in double quotes?

This has proven to be a very annoying limitation in practice.

Either explain why it's a limitation (without using subjective "Annoying"), or drop it altogether.

[dcermak]

"inherit"

Why inherit is in double quotes?

Because it is not classical class based inheritance as used in programming.

This has proven to be a very annoying limitation in practice.

Either explain why it's a limitation (without using subjective "Annoying"), or drop it altogether.

This is a rather specific BCI-Tests problem that we saw in practice. We often have a base image, e.g. bci/golang. And now we have multiple test with their own Container Images classes (e.g. due to different dockerfiles). But since the marks don't "carry over" or "inherit" we have to do this:

golang = pytest.param(Container(…args…), marks=pytest.mark.golang)
param1 = pytest.param(DerivedContainer(base=golang.param[0], containerfile="something"), marks=golang.marks)
param2= pytest.param(DerivedContainer(base=golang.param[0], containerfile="something else"), marks=golang.marks)
# and so on

with this PR, we can now just write:

golang = Container(…args…, marks=pytest.mark.golang)
param1 = DerivedContainer(base=golang, containerfile="something")
param2= DerivedContainer(base=golang, containerfile="something else")
# and so on

and the result is the same