Skip to content

Commit 278a822

Browse files
dcermakdmpop
andauthored
Apply suggestions from code review
Co-authored-by: Dmitri Popov <[email protected]>
1 parent a8a7828 commit 278a822

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

source/usage.rst

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -463,21 +463,20 @@ upstream documentation:
463463
<https://docs.pytest.org/en/latest/example/markers.html#mark-examples>_
464464

465465
It can be beneficial to mark each container for a test suite with a unique
466-
marker, so that you can run the tests only for a single container image. This
467-
would involve wrapping each :py:class:`~pytest_container.container.Container`
466+
marker, so that you can run the tests only for a single container image. This involves wrapping each :py:class:`~pytest_container.container.Container`
468467
and :py:class:`~pytest_container.container.DerivedContainer` in a
469468
``pytest.param()``. This approach two disadvantages:
470469

471470
1. you are now handling ``pytest.ParameterSet`` instance and have to unpack them
472471
to access the underlying :py:class:`~pytest_container.container.Container`
473472
and :py:class:`~pytest_container.container.DerivedContainer`
474473

475-
2. :py:class:`~pytest_container.container.DerivedContainer` do not "inherit" the
474+
2. :py:class:`~pytest_container.container.DerivedContainer` does not "inherit" the
476475
marks from their base containers. This has proven to be a very annoying
477476
limitation in practice.
478477

479478
To remedy this, :py:class:`~pytest_container.container.ContainerBase` now
480-
inherits from ``pytest.ParameterSet`` and can itself take marks via the
479+
inherits from ``pytest.ParameterSet`` and can itself accept marks via the
481480
constructor. These marks automatically carry over into
482481
:py:class:`~pytest_container.container.DerivedContainer` instances:
483482

0 commit comments

Comments
 (0)