Skip to content

Conversation

@n-h-diaz
Copy link
Contributor

@n-h-diaz n-h-diaz commented Nov 18, 2025

This PR migrates usage of /v1/bulk/observations/series/linked to /v2/observation, including:

Note based on gemini comments (more details in comments below): I had to update the test cases a bit, including

  • Changing request params to fit the V2 series limit
  • Not including preferred facets, since V2 doesn't have this concept

@n-h-diaz n-h-diaz marked this pull request as ready for review November 18, 2025 19:11
@n-h-diaz
Copy link
Contributor Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR migrates usage of /v1/bulk/observations/series/linked to /v2/observation. The changes look good overall, covering migration testing, load testing, and memory profiling. I've found a few issues related to the comparability of the new test cases with the old ones they are replacing. Specifically, some entity expressions in the memory profiling and load testing scripts do not match the original V1 requests. Additionally, the memory profiling test has reduced coverage as it no longer tests with and without facets. I've left detailed comments with suggestions for these points.

@n-h-diaz n-h-diaz requested a review from hqpho November 18, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant