fix: Address clippy issues

Author: dashed

src/main.rs

@@ -13,7 +13,6 @@ use git2::{
 };
 use rand::Rng;
 use regex::Regex;
-use serde_json;
 
 // Merge options types
 #[derive(Debug, PartialEq, Clone, Copy)]
@@ -2297,7 +2296,7 @@ impl GitChain {
                             serde_json::from_str(&stdout).unwrap_or_default();
                         if !pr_objects.is_empty() {
                             if let Some(pr_url) = pr_objects
-                                .get(0)
+                                .first()
                                 .and_then(|pr| pr.get("url"))
                                 .and_then(|url| url.as_str())
                             {
@@ -2385,7 +2384,7 @@ impl GitChain {
                     // If draft mode, open the PR in browser separately
                     if draft {
                         let pr_url = String::from_utf8_lossy(&output.stdout).trim().to_string();
-                        if let Some(pr_number) = pr_url.split('/').last() {
+                        if let Some(pr_number) = pr_url.split('/').next_back() {
                             let browse_output =
                                 Command::new("gh").arg("browse").arg(pr_number).output();
 

tests/backup.rs

@@ -108,14 +108,14 @@ fn backup_subcommand() {
     let args: Vec<&str> = vec!["init", "chain_name_2"];
     run_test_bin_expect_ok(&path_to_repo, args);
 
-    assert_eq!(
-        branch_exists(&repo, &backup_name("chain_name_2", "some_branch_2")),
-        false
-    );
-    assert_eq!(
-        branch_exists(&repo, &backup_name("chain_name_2", "some_branch_3")),
-        false
-    );
+    assert!(!branch_exists(
+        &repo,
+        &backup_name("chain_name_2", "some_branch_2")
+    ));
+    assert!(!branch_exists(
+        &repo,
+        &backup_name("chain_name_2", "some_branch_3")
+    ));
 
     let args: Vec<&str> = vec!["backup"];
     let output = run_test_bin_expect_ok(&path_to_repo, args);
@@ -156,13 +156,11 @@ fn backup_subcommand() {
         commit_all(&repo, "message");
     };
 
-    assert!(
-        branch_equal(
-            &repo,
-            "some_branch_3",
-            &backup_name("chain_name_2", "some_branch_3")
-        ) == false
-    );
+    assert!(!branch_equal(
+        &repo,
+        "some_branch_3",
+        &backup_name("chain_name_2", "some_branch_3")
+    ));
 
     let args: Vec<&str> = vec!["backup"];
     let output = run_test_bin_expect_ok(&path_to_repo, args);

tests/common/mod.rs

@@ -18,6 +18,7 @@ where
     path_to_repo
 }
 
+#[allow(dead_code)]
 pub fn generate_path_to_bare_repo<S>(repo_name: S) -> PathBuf
 where
     S: Into<String>,
@@ -47,6 +48,7 @@ where
     repo
 }
 
+#[allow(dead_code)]
 pub fn setup_git_bare_repo<S>(repo_name: S) -> Repository
 where
     S: Into<String>,
@@ -72,6 +74,7 @@ where
     fs::remove_dir_all(&path_to_repo).ok();
 }
 
+#[allow(dead_code)]
 pub fn teardown_git_bare_repo<S>(repo_name: S)
 where
     S: Into<String>,
@@ -99,11 +102,13 @@ pub fn checkout_branch(repo: &Repository, branch_name: &str) {
         .unwrap();
 }
 
+#[allow(dead_code)]
 pub fn branch_exists(repo: &Repository, branch_name: &str) -> bool {
     repo.revparse_single(&("refs/heads/".to_owned() + branch_name))
         .is_ok()
 }
 
+#[allow(dead_code)]
 pub fn branch_equal(repo: &Repository, branch_name: &str, other_branch: &str) -> bool {
     let obj = repo
         .revparse_single(&format!("{}^{{commit}}", branch_name))
@@ -169,6 +174,7 @@ pub fn commit_all(repo: &Repository, message: &str) {
     create_commit(repo, root_tree_oid, message);
 }
 
+#[allow(dead_code)]
 pub fn delete_local_branch(repo: &Repository, branch_name: &str) {
     let mut some_branch = repo.find_branch(branch_name, BranchType::Local).unwrap();
 
@@ -178,6 +184,7 @@ pub fn delete_local_branch(repo: &Repository, branch_name: &str) {
     some_branch.delete().unwrap();
 }
 
+#[allow(dead_code)]
 pub fn get_current_branch_name(repo: &Repository) -> String {
     let head = repo.head().unwrap();
     head.shorthand().unwrap().to_string()
@@ -194,9 +201,9 @@ pub fn create_new_file(path_to_repo: &Path, file_name: &str, file_contents: &str
     writeln!(file, "{}", file_contents).unwrap();
 }
 
+#[allow(dead_code)]
 pub fn append_file(path_to_repo: &Path, file_name: &str, file_contents: &str) {
     let mut file = OpenOptions::new()
-        .write(true)
         .append(true)
         .open(path_to_repo.join(file_name))
         .unwrap();
@@ -222,6 +229,7 @@ where
         .expect("Failed to run git-chain")
 }
 
+#[allow(dead_code)]
 pub fn run_test_bin_expect_err<I, T, P: AsRef<Path>>(current_dir: P, arguments: I) -> Output
 where
     I: IntoIterator<Item = T>,
@@ -257,11 +265,13 @@ where
     output
 }
 
+#[allow(dead_code)]
 pub fn display_outputs(output: &Output) {
     io::stdout().write_all(&output.stdout).unwrap();
     io::stderr().write_all(&output.stderr).unwrap();
 }
 
+#[allow(dead_code)]
 pub fn run_git_command<I, T, P: AsRef<Path>>(current_dir: P, arguments: I) -> Output
 where
     I: IntoIterator<Item = T>,
@@ -281,6 +291,7 @@ where
     output
 }
 
+#[allow(dead_code)]
 pub fn run_test_bin_for_rebase<I, T, P: AsRef<Path>>(current_dir: P, arguments: I) -> Output
 where
     I: IntoIterator<Item = T>,

tests/init.rs

@@ -97,7 +97,7 @@ chain_name
         let count = {
             let mut iter = local_config.entries(Some(&config_chain_name)).unwrap();
             let mut count = 0;
-            while let Some(_) = iter.next() {
+            while iter.next().is_some() {
                 count += 1;
             }
             count
@@ -113,7 +113,7 @@ chain_name
         let count = {
             let mut iter = local_config.entries(Some(&config_chain_order)).unwrap();
             let mut count = 0;
-            while let Some(_) = iter.next() {
+            while iter.next().is_some() {
                 count += 1;
             }
             count
@@ -131,7 +131,7 @@ chain_name
         let count = {
             let mut iter = local_config.entries(Some(&config_root_branch)).unwrap();
             let mut count = 0;
-            while let Some(_) = iter.next() {
+            while iter.next().is_some() {
                 count += 1;
             }
             count

tests/merge.rs

@@ -6827,7 +6827,7 @@ fn merge_subcommand_complex_conflicts() {
         );
 
         // Rather than asserting on a specific branch, verify it's a valid branch in our chain
-        let valid_chain_branches = vec!["master", "feature_1", "feature_2"];
+        let valid_chain_branches = ["master", "feature_1", "feature_2"];
         let is_valid_chain_branch = valid_chain_branches.contains(&branch_after_abort.as_str());
         assert!(
             is_valid_chain_branch,

tests/rebase.rs

@@ -1,5 +1,3 @@
-use console;
-
 use git2::RepositoryState;
 
 #[path = "common/mod.rs"]