Rename the module to anemic, address the import issue, refactor DCAN #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalgu90
changed the title
| return logits | ||
|
|
||
|
|
||
| class WordEmbeddingLayer(nn.Module): |
Collaborator
There was a problem hiding this comment.
We can reuse this class from other models?
Collaborator
There was a problem hiding this comment.
We took a call to follow this design: https://huggingface.co/blog/transformers-design-philosophy. So, every file will have all layers which are used in that model.
abheesht17
approved these changes
Sep 3, 2022
Collaborator
abheesht17
left a comment
abheesht17
left a comment
There was a problem hiding this comment.
LGTM! Thanks, @dalgu90, for working on this. Approved the PR :)
abheesht17
reviewed
Sep 3, 2022
This was referenced Sep 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi team. I changed the module name and the related import statements. This PR also addresses the problem of doing
import *for the Config, and reactors DCAN for the.src->anemicand changed all the statements related.__init__.py. Removed the import statements written just for ConfigMapper.modules.layersmodule since it's only used in DCAN.By the second change, if any of the
anemicsubmodules are imported, then all the classes ofanemicwill be loaded recursively by the__init__.pyfiles so that the ConfigMapper will get the classes.FYI, all the import statements are absolute imports, not relative, following this guide.