Release v2.0.0

Author: dabroek

CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## v2.0.0 - 13 Feb, 2020
+
+Updates all outdated dependencies. Updating Jest from v20 to v25 revealed that not all tests that asserted a promise rejecting were succeeding as expected. This resulted in the breaking change mentioned below.
+
+### Breaking Changes
+
+- The `set` method now actually checks `isCacheableValue` before setting a value
+- Dropped support for Node.js < 8.3

dist/index.js

@@ -5,24 +5,21 @@ function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'defau
 var Redis = _interopDefault(require('redis'));
 
 var redisStore = function redisStore() {
-  for (var _len = arguments.length, args = Array(_len), _key = 0; _key < _len; _key++) {
-    args[_key] = arguments[_key];
-  }
-
-  var redisCache = Redis.createClient.apply(Redis, args);
+  var redisCache = Redis.createClient.apply(Redis, arguments);
   var storeArgs = redisCache.options;
-
   return {
     name: 'redis',
     getClient: function getClient() {
       return redisCache;
     },
     set: function set(key, value, options, cb) {
+      var self = this;
       return new Promise(function (resolve, reject) {
         if (typeof options === 'function') {
           cb = options;
           options = {};
         }
+
         options = options || {};
 
         if (!cb) {
@@ -31,6 +28,10 @@ var redisStore = function redisStore() {
           };
         }
 
+        if (!self.isCacheableValue(value)) {
+          return cb(new Error("\"".concat(value, "\" is not a cacheable value")));
+        }
+
         var ttl = options.ttl || options.ttl === 0 ? options.ttl : storeArgs.ttl;
         var val = JSON.stringify(value) || '"undefined"';
 
@@ -42,14 +43,13 @@ var redisStore = function redisStore() {
       });
     },
     mset: function mset() {
-      for (var _len2 = arguments.length, args = Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
-        args[_key2] = arguments[_key2];
+      for (var _len = arguments.length, args = new Array(_len), _key = 0; _key < _len; _key++) {
+        args[_key] = arguments[_key];
       }
 
-      var _this = this;
-
+      var self = this;
       return new Promise(function (resolve, reject) {
-        var cb = void 0;
+        var cb;
         var options = {};
 
         if (typeof args[args.length - 1] === 'function') {
@@ -67,24 +67,25 @@ var redisStore = function redisStore() {
         }
 
         var ttl = options.ttl || options.ttl === 0 ? options.ttl : storeArgs.ttl;
+        var multi;
 
-        var multi = void 0;
         if (ttl) {
           multi = redisCache.multi();
         }
 
-        var key = void 0;
-        var value = void 0;
+        var key;
+        var value;
         var parsed = [];
+
         for (var i = 0; i < args.length; i += 2) {
           key = args[i];
           value = args[i + 1];
-
           /**
            * Make sure the value is cacheable
            */
-          if (!_this.isCacheableValue(value)) {
-            return cb(new Error('value cannot be ' + value));
+
+          if (!self.isCacheableValue(value)) {
+            return cb(new Error("\"".concat(value, "\" is not a cacheable value")));
           }
 
           value = JSON.stringify(value) || '"undefined"';
@@ -114,16 +115,18 @@ var redisStore = function redisStore() {
           };
         }
 
-        redisCache.get(key, handleResponse(cb, { parse: true }));
+        redisCache.get(key, handleResponse(cb, {
+          parse: true
+        }));
       });
     },
     mget: function mget() {
-      for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
-        args[_key3] = arguments[_key3];
+      for (var _len2 = arguments.length, args = new Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+        args[_key2] = arguments[_key2];
       }
 
       return new Promise(function (resolve, reject) {
-        var cb = void 0;
+        var cb;
         var options = {};
 
         if (typeof args[args.length - 1] === 'function') {
@@ -140,16 +143,18 @@ var redisStore = function redisStore() {
           };
         }
 
-        redisCache.mget.apply(redisCache, [].concat(args, [handleResponse(cb, { parse: true })]));
+        redisCache.mget.apply(redisCache, [].concat(args, [handleResponse(cb, {
+          parse: true
+        })]));
       });
     },
     del: function del() {
-      for (var _len4 = arguments.length, args = Array(_len4), _key4 = 0; _key4 < _len4; _key4++) {
-        args[_key4] = arguments[_key4];
+      for (var _len3 = arguments.length, args = new Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+        args[_key3] = arguments[_key3];
       }
 
       return new Promise(function (resolve, reject) {
-        var cb = void 0;
+        var cb;
         var options = {};
 
         if (typeof args[args.length - 1] === 'function') {
@@ -182,7 +187,7 @@ var redisStore = function redisStore() {
     },
     keys: function keys() {
       var pattern = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : '*';
-      var cb = arguments[1];
+      var cb = arguments.length > 1 ? arguments[1] : undefined;
       return new Promise(function (resolve, reject) {
         if (typeof pattern === 'function') {
           cb = pattern;
@@ -217,14 +222,14 @@ var redisStore = function redisStore() {
 
 function handleResponse(cb) {
   var opts = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
-
   return function (err, result) {
     if (err) {
       return cb && cb(err);
     }
 
     if (opts.parse) {
       var isMultiple = Array.isArray(result);
+
       if (!isMultiple) {
         result = [result];
       }
@@ -235,9 +240,9 @@ function handleResponse(cb) {
         } catch (e) {
           return cb && cb(e);
         }
+
         return _result;
       });
-
       result = isMultiple ? result : result[0];
     }
 
@@ -247,7 +252,7 @@ function handleResponse(cb) {
 
 var methods = {
   create: function create() {
-    return redisStore.apply(undefined, arguments);
+    return redisStore.apply(void 0, arguments);
   }
 };
 

package.json

@@ -2,7 +2,7 @@
   "name": "cache-manager-redis-store",
   "author": "Matthijs Dabroek <[email protected]>",
   "description": "Redis store for node-cache-manager",
-  "version": "1.5.0",
+  "version": "2.0.0",
   "license": "MIT",
   "main": "dist/index.js",
   "repository": {
@@ -33,6 +33,6 @@
     "rollup-plugin-babel": "^4.3.3"
   },
   "engines": {
-    "node": ">=4.2.0"
+    "node": ">= 8.3"
   }
 }