Remove patch dependencies on Windows and Mac platforms to facilitate building #300
Milestone
Comments
cztomczak
added a commit
that referenced
this issue
Feb 17, 2017
There is still issue with building vcproj files to be resolved. Currently supported on Windows is only Python 2.7 32-bit. Remove patch deps on Windows and Mac platforms to facilitate building (#300, #231, #251). Create tools/build.py and tools/build_module.py (#210). Cleanup in directories due to new build tools. Update tools/automate.py. DragData methods become Linux-only: GetImage(), HasImage(). This functionality will be available on all platforms when patch is merged into upstream (#251).
|
Done. See commits in #295. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Linux Issue #231 patch is mandatory. However on Windows and Mac this is not required. Update patch.py so that this patch is applied only on Linux.
Also Issue #251 patch could be removed on Windows/Mac temporarily to facilitate building on these platforms. Either way this patch is going to be merged in upstream, so this funcionatlity would be re-introduced soon. Just update DragData (SetImage, GetImage, HasImage) documentation that this is Linux-only for now.
Issue #125 patch seems that it won't work anymore with latest CEF. See the latest comment in that issue for details. However this can stay untouched in patch.py and be applied for all platforms. It doesn't matter if it fails.
The text was updated successfully, but these errors were encountered: