mutations: open mutation editor in a new tab

[oliver-sanders]

Supersedes: #881

The mutation editor is opened when the user clicks on the "edit" (pencil) icon from the mutation list or if a mutation cannot be run without additional information from the user. This allows additional information to be specified or edited before running the mutation.

The editor opens in an overlay which works ok, however, has the side effect of covering over the workflow obscuring information which might be helpful whilst configuring the mutation such as task names and status.

What would be really helpful is if this editor could open in a new tab (like the Cylc "views") rather than in an overlay. In fact we already have the "mutations view", this is a development view that is no longer needed and scheduled for demolition (#881).

Proposal:

• Remove the old "mutations view" (at least from the views list) - views: remove the dev mutations view #1027
• When the UI is open on a "workflows" route (i.e. #/workflows/).
  • The mutation editor should open in a new tab (i.e. the "mutations view") rather than in an overlay.
• When the UI is open at a different route (e.g. #/Dashboard).
  • We can't open a new tab because we don't have a Lumino instance so we could either:
  • Navigate to the workflow view and open a new tab there (hard to do and jumpy UI).
  • Or continue to open the mutation editor in an overlay as we presently do (ok IMO).

Pull requests welcome!

[hjoliver]

has the side effect of covering over the workflow obscuring information which might be helpful whilst configuring the mutation such as task names and status.

That's something I've noted too.

I'm not sure a lumino tab is the ideal solution though. It will mess with existing tab layout, which might be annoying.

What about a movable overlay - is that possible?

[oliver-sanders]

It wouldn't mess with the layout, would just open a new tab the same way it would if you opened a new view. The user is then free to do with that tab what they will e.g. split the layout.

This was requested by a user who wanted to have the table view side-by-side with the mutation editor. A movable overlay would prevent you from scrolling the table etc.

[MetRonnie]

How about a side panel that opens on the right?

[oliver-sanders]

Perfectly possible, however, that would mess with the tab layout by altering its dimensions.

Personally I think using the existing tabbing system would be the easiest/nicest approach. The new tab would fit in with the existing layout without altering it's dimensions or interrupting the user's workflow. It wouldn't require any extra code, components or UI elements keeping things simple for us and our users.