fix: Preserve error order when deduplicating errors #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when deduplicating errors, the errors were first sorted and then deduplicated. This lost the ordering of errors which can be useful for understanding why a value is not compatible with a declaration. Signed-off-by: Graham Dennis <[email protected]>
GrahamDennis
force-pushed
the
gdennis/stable-error-sorting
branch
from
d59ed35 to
b57f45f
Compare
Signed-off-by: Graham Dennis <[email protected]>
GrahamDennis
force-pushed
the
gdennis/stable-error-sorting
branch
from
b57f45f to
6b80a11
Compare
Signed-off-by: Graham Dennis <[email protected]>
|
Thanks for the patch! Unfortunately this seems to introduce quadratic behavior, which could be problematic as large configurations can run into thousands of errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when deduplicating errors, the errors were first sorted and
then deduplicated. This lost the ordering of errors which can be useful
for understanding why a value is not compatible with a declaration.
Resolves #3859