internal/ci: test and release on Go 1.24

Our stable release binaries need to be built with the latest major
version of Go, as otherwise users will see version incompatibility
errors when trying to use `cue get go` with the latest Go toolchain.

We also disable staticcheck at this point, given that the pinned version
does not support Go 1.24 yet, and updating staticcheck to get newer
warnings is not something we want to do in backporting release branches;
we already do that in master.

Updates #3868.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I8f18f117d4148a9bb93712a4fcc25192748eeee8
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1212810
Reviewed-by: Roger Peppe <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mvdan

.github/workflows/release.yaml

@@ -57,7 +57,7 @@ jobs:
         uses: actions/setup-go@v5
         with:
           cache: false
-          go-version: 1.23.5
+          go-version: 1.24.2
       - name: Set common go env vars
         run: |-
           go env -w GOTOOLCHAIN=local

.github/workflows/trybot.yaml

@@ -21,7 +21,7 @@ jobs:
       matrix:
         go-version:
           - 1.22.x
-          - 1.23.x
+          - 1.24.x
         runner:
           - ubuntu-24.04
           - macos-14
@@ -107,20 +107,20 @@ jobs:
           github.repository == 'cue-lang/cue' && (((github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-branch.')) && (! (contains(github.event.head_commit.message, '
           Dispatch-Trailer: {"type":"')))) || github.ref == 'refs/heads/ci/test')
         run: go clean -testcache
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Early git and code sanity checks
         run: go run ./internal/ci/checks
       - if: |-
           ((github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-branch.')) && (! (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"')))) || !(matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+          Dispatch-Trailer: {"type":"')))) || !(matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Test
         run: go test ./...
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Test with -race
         env:
           GORACE: atexit_sleep_ms=10
         run: go test -race ./...
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Test on 32 bits
         env:
           GOARCH: "386"
@@ -133,35 +133,29 @@ jobs:
           credentials_json: ${{ secrets.E2E_GCLOUD_KEY }}
         if: |-
           github.repository == 'cue-lang/cue' && (((github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-branch.')) && (! (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: gcloud auth for end-to-end tests
       - if: |-
           github.repository == 'cue-lang/cue' && (((github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-branch.')) && (! (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: gcloud setup for end-to-end tests
         uses: google-github-actions/setup-gcloud@v2
       - if: |-
           github.repository == 'cue-lang/cue' && (((github.ref == 'refs/heads/master' || startsWith(github.ref, 'refs/heads/release-branch.')) && (! (contains(github.event.head_commit.message, '
-          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+          Dispatch-Trailer: {"type":"')))) || (github.ref == 'refs/heads/ci/test')) && (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: End-to-end test
         run: |-
           cd internal/_e2e
           go test -race
         env:
           CUE_TEST_TOKEN: ${{ secrets.E2E_PORCUEPINE_CUE_TOKEN }}
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Go checks
         run: |-
           go vet ./...
           go mod tidy
           (cd internal/_e2e && go test -run=-)
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
-        name: staticcheck
-        uses: dominikh/staticcheck-action@v1
-        with:
-          version: 2024.1.1
-          install-go: false
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Check all git tags are available
         run: |-
           cd $(mktemp -d)
@@ -177,7 +171,7 @@ jobs:
           	echo "Did you forget about refs/attic branches? https://github.com/cue-lang/cue/wiki/Notes-for-project-maintainers"
           	exit 1
           fi
-      - if: (matrix.go-version == '1.23.x' && matrix.runner == 'ubuntu-24.04')
+      - if: (matrix.go-version == '1.24.x' && matrix.runner == 'ubuntu-24.04')
         name: Generate
         env:
           CUE_TOKEN: ${{ secrets.NOTCUECKOO_CUE_TOKEN }}

internal/ci/github/trybot.cue

@@ -181,16 +181,6 @@ workflows: trybot: _repo.bashWorkflow & {
 				go mod tidy
 				(cd internal/_e2e && go test -run=-)
 				"""
-		}, {
-			name: "staticcheck"
-			// TODO(mvdan): once we can do 'go tool staticcheck' with Go 1.24+,
-			// then using this action is probably no longer worthwhile.
-			// Note that we should then persist staticcheck's cache too.
-			uses: "dominikh/staticcheck-action@v1"
-			with: {
-				version:      "2024.1.1" // Pin a version for determinism.
-				"install-go": false      // We install Go ourselves.
-			}
 		},
 	]
 

internal/ci/repo/repo.cue

@@ -33,7 +33,7 @@ windowsMachine: "windows-2022"
 // Use the latest Go version for extra checks,
 // such as running tests with the data race detector.
 // This may be a release candidate if we are late into a Go release cycle.
-latestGo: "1.23.x"
+latestGo: "1.24.x"
 
 // The list of all Go versions that we run our tests on.
 // This typically goes back one major Go version, as we support two at a time.
@@ -42,7 +42,7 @@ matrixGo: ["1.22.x", latestGo]
 // Use a specific latest version for release builds.
 // Note that we don't want ".x" for the sake of reproducibility,
 // so we instead pin a specific Go release.
-pinnedReleaseGo: "1.23.5"
+pinnedReleaseGo: "1.24.2"
 
 goreleaserVersion: "v2.5.0"