You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bit of a chicken and egg problem with the perl tests here - they rely on the current published version of the CCK, whose messages don't include the new field, which is causing the failure. Any thoughts on how to address this @ehuelsmann?
@davidjgoss looking at the test I think we can change them a little so. So instead of comparing the round trip ndjson --> object --> ndjson and comparing the result we can do object --> ndjson --> object and compare that result. That way we don't need the CCK at all and the code will change along with that specific message object.
Though I think it would be even better to include a testdata folder with (for now) a single message that all implementations try to round trip. That way we won't have to update N implementations manually.
I think hand picking a few interesting cases from the current CCK should be sufficient.
For this repo we are mostly concerned with ensuring the serialization works. This means that both legs of a round trip work.
Wether or not the contents of a message is correct and consistent with the other messages in a report file isn't a concern here. So we don't need a cucumber implementation to generate them.
The text was updated successfully, but these errors were encountered: