Replace existing feature with the noruba ones

Author: vincent-psarga

.circleci/config.yml

@@ -39,12 +39,7 @@ commands:
       - run:
           name: run tests
           command: |
-            bundle exec rspec
-            bundle exec cucumber
-            cd noruba
-            bundle exec cucumber
-            cd ..
-            bundle exec rubocop
+            bundle exec rake
 
   test_allow_failure:
     description: "Run tests (allow failure so workflow is not marked as failed)"
@@ -67,21 +62,8 @@ jobs:
           name: run tests
           command: |
             bundle exec rspec
-            bundle exec cucumber --retry 8 --no-strict-flaky
-
-  build_windows_noruba:
-    executor: win/default
-    working_directory: ~/repo
-    steps:
-      - add_windows_dependencies
-      - build
-      - run:
-          name: run tests
-          command: |
-            cd noruba
             bundle exec cucumber
 
-
   build-ruby-2_3:
     docker:
       - image: circleci/ruby:2.3
@@ -210,7 +192,6 @@ workflows:
   build:
     jobs:
       - build_windows
-      - build_windows_noruba
       - build-ruby-2_3
       - build-ruby-2_4
       - build-ruby-2_5

features/docs/api/list_step_defs_as_json.feature

@@ -1,4 +1,3 @@
-@spawn
 Feature: List step defs as json
 
   In order to build tools on top of Cucumber
@@ -17,11 +16,13 @@ Feature: List step defs as json
     And a file named "list_step_definitions.rb" with:
       """
       require 'cucumber'
-      puts Cucumber::StepDefinitions.new.to_json
-
+      File.open('steps.json', 'w') do |file|
+        file.write Cucumber::StepDefinitions.new.to_json
+      end
       """
     When I run `bundle exec ruby list_step_definitions.rb`
-    Then it should pass with JSON:
+    Then it should pass
+    And file "steps.json" should contain JSON:
       """
       [
         {
@@ -44,10 +45,13 @@ Feature: List step defs as json
     And a file named "list_step_definitions.rb" with:
       """
       require 'cucumber'
-      puts Cucumber::StepDefinitions.new(:autoload_code_paths => ['my_weird']).to_json
+      File.open('steps.json', 'w') do |file|
+        file.write Cucumber::StepDefinitions.new(:autoload_code_paths => ['my_weird']).to_json
+      end
       """
     When I run `bundle exec ruby list_step_definitions.rb`
-    Then it should pass with JSON:
+    Then it should pass
+    And file "steps.json" should contain JSON:
       """
       [
         {

features/docs/api/run_cli_main_with_existing_runtime.feature

@@ -1,4 +1,3 @@
-@spawn
 Feature: Run Cli::Main with existing Runtime
 
   This is the API that Spork uses. It creates an existing runtime.

features/docs/cli/fail_fast.feature

@@ -1,4 +1,4 @@
-@spawn
+@disable_fail_fast
 Feature: Fail fast
 
   The --fail-fast flag causes Cucumber to exit immediately after the first

features/docs/cli/randomize.feature

@@ -57,7 +57,7 @@ Feature: Randomize
     When I run `cucumber`
     Then it should pass
 
-  @spawn
+  @global_state
   Scenario: Run scenarios randomized
     When I run `cucumber --order random:41544 -q`
     Then it should fail
@@ -98,15 +98,15 @@ Feature: Randomize
       4 steps (2 failed, 2 passed)
 
       Randomized with seed 41544
-
       """
 
+  @force_legacy_loader
   Scenario: Rerun scenarios randomized
     When I run `cucumber --order random --format summary`
     And I rerun the previous command with the same seed
     Then the output of both commands should be the same
 
-  @spawn
+  @global_state
   Scenario: Run scenarios randomized with some skipped
     When I run `cucumber --tags "not @skipme" --order random:41544 -q`
     Then it should fail with exactly:

features/docs/cli/retry_failing_tests.feature

@@ -28,16 +28,16 @@ Feature: Retry failing tests
         Fails-forever ✗
         Fails-forever ✗
 
-      Solid
-        Solid ✓
-
       Fails-once feature
         Fails-once ✗
         Fails-once ✓
 
       Fails-twice feature
         Fails-twice ✗
         Fails-twice ✗
+
+      Solid
+        Solid ✓
       """
 
   Scenario: Retry twice, so Fails-twice starts to pass too
@@ -54,9 +54,6 @@ Feature: Retry failing tests
         Fails-forever ✗
         Fails-forever ✗
 
-      Solid
-        Solid ✓
-
       Fails-once feature
         Fails-once ✗
         Fails-once ✓
@@ -65,6 +62,9 @@ Feature: Retry failing tests
         Fails-twice ✗
         Fails-twice ✗
         Fails-twice ✓
+
+      Solid
+        Solid ✓
       """
 
   Scenario: Flaky scenarios gives exit code zero in non-strict mode
@@ -90,8 +90,8 @@ Feature: Retry failing tests
     Then it should fail with:
       """
       Flaky Scenarios:
-      cucumber features/fails_once.feature:2
-      cucumber features/fails_twice.feature:2
+      cucumber features/fails-once_feature.feature:2
+      cucumber features/fails-twice_feature.feature:2
 
       3 scenarios (2 flaky, 1 passed)
       """

features/docs/cli/specifying_multiple_formatters.feature

@@ -1,4 +1,3 @@
-@spawn
 Feature: Running multiple formatters
 
   When running cucumber, you are able to using multiple different

features/docs/defining_steps/nested_steps.feature

@@ -103,7 +103,7 @@ Feature: Nested Steps
       Liouville
       """
 
-  @spawn @todo-jruby @wip-jruby
+  @todo-jruby @wip-jruby
   Scenario: Backtrace doesn't skip nested steps
     Given a file named "features/nested_steps.feature" with:
       """gherkin
@@ -112,7 +112,7 @@ Feature: Nested Steps
         Scenario: Test Scenario 1
           Given two turtles
       """
-    Given a step definition that looks like this:
+    Given a file named "features/step_definitions/step_definition.rb" with:
       """ruby
       Given /two turtles/ do
         step "I have a couple turtles"
@@ -124,8 +124,8 @@ Feature: Nested Steps
     Then it should fail with:
       """
       error (RuntimeError)
-      ./features/step_definitions/steps2.rb:5:in `/I have a couple turtles/'
-      ./features/step_definitions/steps2.rb:2:in `/two turtles/'
+      ./features/step_definitions/step_definition.rb:5:in `/I have a couple turtles/'
+      ./features/step_definitions/step_definition.rb:2:in `/two turtles/'
       features/nested_steps.feature:4:in `two turtles'
 
       Failing Scenarios:

features/docs/defining_steps/printing_messages.feature

@@ -75,48 +75,46 @@ Feature: Pretty formatter - Printing messages
           Given I log the world
       """
 
-    # Don't know why, but we need to spawn this for JRuby otherwise it gives wierd errors
-    @spawn
     Scenario: Delayed messages feature
       When I run `cucumber --quiet --format pretty features/f.feature`
       Then the stderr should not contain anything
       And the output should contain:
       """
-      Feature: 
+      Feature:
 
-        Scenario: 
+        Scenario:
           Given I use log with text "Ann"
             Ann
           And this step passes
 
-        Scenario: 
+        Scenario:
           Given I use multiple logs
             Multiple
             Announce
             Me
           And this step passes
 
-        Scenario Outline: 
+        Scenario Outline:
           Given I use message <ann> in line <line>
 
-          Examples: 
+          Examples:
             | line | ann   |
             | 1    | anno1 |
             | 2    | anno2 |
             | 3    | anno3 |
 
-        Scenario: 
+        Scenario:
           Given I use log and step fails
             Announce with fail
              (RuntimeError)
             ./features/step_definitions/log_steps.rb:18:in `/^I use log and step fails$/'
             features/f.feature:21:in `I use log and step fails'
           And this step passes
 
-        Scenario Outline: 
+        Scenario Outline:
           Given I use message <ann> in line <line> with result <result>
 
-          Examples: 
+          Examples:
             | line | ann   | result |
             | 1    | anno1 | fail   |  Line: 1: anno1
              (RuntimeError)
@@ -132,7 +130,7 @@ Feature: Pretty formatter - Printing messages
         Ann
         ..
         Multiple
-        
+
         Announce
         Me
         ..UUU

features/docs/exception_in_after_hook.feature

@@ -21,7 +21,6 @@ Feature: Exception in After Block
       end
       """
 
-  @spawn
   Scenario: Handle Exception in standard scenario step and carry on
     Given a file named "features/naughty_step_in_scenario.feature" with:
       """
@@ -54,7 +53,6 @@ Feature: Exception in After Block
 
       """
 
-  @spawn
   Scenario: Handle Exception in scenario outline table row and carry on
     Given a file named "features/naughty_step_in_scenario_outline.feature" with:
       """
@@ -81,7 +79,7 @@ Feature: Exception in After Block
         Scenario Outline: Naughty Step
           Given this step <Might Work>
 
-          Examples: 
+          Examples:
             | Might Work             |
             | passes                 |
             | does something naughty |

features/docs/exception_in_before_hook.feature

@@ -14,7 +14,6 @@ Feature: Exception in Before Block
       end
       """
 
-  @spawn
   Scenario: Handle Exception in standard scenario step and carry on
     Given a file named "features/naughty_step_in_scenario.feature" with:
       """
@@ -56,12 +55,12 @@ Feature: Exception in Before Block
     Then it should fail with exactly:
       """
       Feature: Sample
-      
+
         Background:              # features/naughty_step_in_before.feature:3
             I cannot even start this scenario (SomeSetupException)
             ./features/support/env.rb:4:in `Before'
           Given this step passes # features/step_definitions/steps.rb:1
-      
+
         Scenario: Run a good step # features/naughty_step_in_before.feature:6
           Given this step passes  # features/step_definitions/steps.rb:1
 

features/docs/formatters/json_formatter.feature

@@ -104,7 +104,6 @@ Feature: JSON output formatter
       """
 
   # Need to investigate why this won't pass in-process. error_message doesn't get det?
-  @spawn
   Scenario: one feature, one passing scenario, one failing scenario
     When I run `cucumber --format json features/one_passing_one_failing.feature`
     Then it should fail with JSON:
@@ -304,7 +303,6 @@ Feature: JSON output formatter
 
     """
 
-  @spawn
   Scenario: scenario outline
     When I run `cucumber --format json features/outline.feature`
     Then it should fail with JSON:
@@ -450,7 +448,6 @@ Feature: JSON output formatter
 
     """
 
-  @spawn
   Scenario: scenario outline expanded
     When I run `cucumber --expand --format json features/outline.feature`
     Then it should fail with JSON:

features/docs/formatters/junit_formatter.feature

@@ -73,7 +73,6 @@ Feature: JUnit output formatter
       end
       """
 
-  @spawn
   Scenario: one feature, one passing scenario, one failing scenario
     When I run `cucumber --format junit --out tmp/ features/one_passing_one_failing.feature`
     Then it should fail with:
@@ -115,7 +114,6 @@ Feature: JUnit output formatter
 
       """
 
-  @spawn
   Scenario: one feature in a subdirectory, one passing scenario, one failing scenario
     When I run `cucumber --format junit --out tmp/ features/some_subdirectory/one_passing_one_failing.feature --require features`
     Then it should fail with:
@@ -260,7 +258,6 @@ can't convert .* into String \(TypeError\)
 You *must* specify --out DIR for the junit formatter
       """
 
-  @spawn
   Scenario: strict mode, one feature, one scenario outline, four examples: one passing, one failing, one pending, one undefined
     When I run `cucumber --strict --format junit --out tmp/ features/scenario_outline.feature`
     Then it should fail with:
@@ -339,7 +336,6 @@ You *must* specify --out DIR for the junit formatter
 
       """
 
-  @spawn
   Scenario: strict mode with --expand option, one feature, one scenario outline, four examples: one passing, one failing, one pending, one undefined
     When I run `cucumber --strict --expand --format junit --out tmp/ features/scenario_outline.feature`
     Then it should fail with exactly:
@@ -418,7 +414,6 @@ You *must* specify --out DIR for the junit formatter
 
       """
 
-  @spawn
   Scenario: run test cases from different features interweaved
     When I run `cucumber --format junit --out tmp/ features/one_passing_one_failing.feature:3 features/pending.feature:3 features/one_passing_one_failing.feature:6`
     Then it should fail with:

features/docs/getting_started.feature

@@ -3,7 +3,6 @@ Feature: Getting started
   To get started, just open a command prompt in an empty directory and run
   `cucumber`. You'll be prompted for what to do next.
 
-  @spawn
   Scenario: Run Cucumber in an empty directory
     Given a directory without standard Cucumber project directory structure
     When I run `cucumber`