Skip to content

Commit 923e294

Browse files
authored
do not instantiate tcp connector before creating an asynchronous loop (#295)
1 parent e398d8f commit 923e294

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

cterasdk/clients/async_requests.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@
1212
class Session:
1313
"""Asynchronous HTTP Session"""
1414

15-
def __init__(self, **kwargs):
16-
self._kwargs = kwargs
15+
def __init__(self, settings, trace):
16+
self._settings = settings
17+
self._trace = trace
1718
self._session = None
1819

1920
@property
2021
def session(self):
2122
if self.closed:
22-
self._session = aiohttp.ClientSession(**self._kwargs)
23+
self._session = aiohttp.ClientSession(**self._settings, **self._trace)
2324
return self._session
2425

2526
@property

cterasdk/clients/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def __init__(self, builder=None, session=None, settings=None, authenticator=None
7070
if settings:
7171
default_settings.update(**settings.kwargs)
7272

73-
self._session = session if session else async_requests.Session(**default_settings, **TraceSettings())
73+
self._session = session if session else async_requests.Session(default_settings, TraceSettings())
7474

7575
def clone(self, definition, builder=None, authenticator=None):
7676
"""

0 commit comments

Comments
 (0)