Skip to content

Styles created multiple times when using function values #1361

@sergnek

Description

@sergnek

Expected behavior:
Duplicate styles shouldn't be created.

Describe the bug:
On every component render, in which useStyles prop changes, new duplicate styles are created. I've managed to reproduce the bug in Codesandbox. To see it:

  1. Open codesandbox link from below
  2. Inspect red text element and see styles applied
  3. Click on button few times to cause component re-render
  4. Inspect some another element on the page and the red text again.
  5. Notice duplicate styles
    The styles are duplicated only for elements styled with css selector. If you check styles on the element with container class, you'll see there is no duplication there.

Codesandbox link:
https://codesandbox.io/s/react-jss-playground-7ftrs?file=/index.js

Versions (please complete the following information):

  • jss: 10.1.1
  • Browser [e.g. chrome, safari]: any
  • OS [e.g. Windows, macOS]: any

79044719-7820f180-7c0f-11ea-9134-42442b8c84af

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIt went crazy and killed everyone.help wantedimportantThe thing you do when you wake up!perf

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions