V4 #12
V4 #12
Conversation
…RL.createObjectURL, so the app no longer accumulates unreleased blob URLs. Updated iteration-api.test.js expectations to match the new scheme and dropped the unused object URL stubs
…pp.js), and it is removed both when the modal closes and during destroy() so we don’t leak the listener
… forced iteration tiles into a single-column grid, and switched the preview frames to a 3:2 aspect ratio so each render scales tall enough to fill the available space on every screen size
…ead of URL.createObjectURL, so the app no longer accumulates unreleased blob URLs. Updated iteration-api.test.js expectations to match the new scheme and dropped the unused object URL stubs" This reverts commit 816ea53.
…3/2] utility on the tile preview container in app.js, so the layout stays the same without tripping CSP
…ription that shows only a short preview by default and reveals the full copy plus user notes on demand, reducing visual noise while keeping the annotation flow intact
…eps walls, openings, and ceiling heights fixed to the source photo. - Documented that reference images serve style cues only and must not influence room geometry. - Added unit test expectations around the new guardrail language to prevent regressions.
…ction so the "Start generating" button lives directly beneath the Silent Room Brief card. - Hid the generate-next-iteration bar until the first gallery exists and stopped mounting the compare-final modal until a hi-res candidate is available, keeping the pre-run UI minimal. - Added layout/unit tests that lock in the new control order and lazy modal creation to catch regressions.
…en class and the native hidden attribute; this keeps the bar truly out of view (and out of the accessibility tree) until an iteration selection exists, matching the Playwright expectation. Added generate bar toggles the hidden attribute with selection state in app.layout.test.js to lock in the behavior in unit tests
…e summary paragraph and constraint bullets can be tuned before launching a run. - Added guardrails for constraint rows (add/remove up to five) and wired state updates on input events so iteration prompts reuse the edited text. - Extended the layout spec to assert the editable controls render with the generated brief content.
…indows, and room entries stay fixed to the source photo. - Updated prompt unit tests to assert the new guardrail language for future regressions.
…pec and cut redundant architectural guardrails. - Adjusted iteration prompt unit tests to check the leaner phrasing while keeping geometry preservation coverage.
Summary of ChangesHello @cs-util, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly advances the project by transitioning its core functionality to an iterative design workflow, allowing users to refine interior designs through successive rounds of AI-generated variants. This major functional change is complemented by substantial improvements in code quality, maintainability, and documentation. The introduction of a standardized code formatter and updated development tool configurations ensures a more consistent and robust codebase, while rewritten documentation provides clearer guidelines for contributors and users alike. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces significant improvements to the project's documentation, tooling, and core application logic. The rewrite of AGENTS.md and the introduction of .prettierrc.json establish clearer standards for contributors. The major refactoring to implement the "V2" iterative workflow is well-executed, with new logic cleanly separated into modules like iteration-api.js and iteration-prompts.js. I've identified a critical inconsistency between the README.md and package.json regarding the CSS build step, along with some minor documentation formatting issues that should be addressed. Overall, this is a great step forward for the project's maintainability and clarity.
| "check:cycles": "madge --circular --extensions js src", | ||
| "check:cycles": "madge --circular --extensions js --exclude '\\.stryker-tmp|playwright-report' src", | ||
| "check:boundaries": "depcruise -c config/.dependency-cruiser.js src", | ||
| "build:css": "tailwindcss -i ./src/tailwind.input.pcss -o ./styles/app.css --minify", |
There was a problem hiding this comment.
The build:css script has been removed, but the README.md file still contains instructions to run it. This creates a contradiction in the development setup documentation. Please update README.md to remove the reference to npm run build:css to align with the project's move to using the Tailwind Play CDN, which doesn't require a build step.
| - Before PR/release: `npm run validate:all` (tests + checks + mutation) | ||
| - Always run commands in a real terminal and include actual output in notes/PRs. | ||
| - Source composed of small, focused modules in `src/` (`components/`, `utils/`, ..) with colocated tests | ||
| - Frequently during development and before each commit: run `npm test` |
There was a problem hiding this comment.
This line has a trailing whitespace character at the end, which should be removed for consistent formatting.
| - Frequently during development and before each commit: run `npm test` | |
| - Frequently during development and before each commit: run `npm test` |
| - Large refactors | ||
| - Changing public URLs or Pages config | ||
| ## TDD Failure loop to use | ||
| 1. Prefer the simplest fix first |
There was a problem hiding this comment.
This line has a trailing whitespace character at the end. Please remove it to maintain consistent formatting.
| 1. Prefer the simplest fix first | |
| 1. Prefer the simplest fix first |
| @claude please implement the user authentication feature described in this issue | ||
| ``` | ||
|
|
||
| ### 2. Cursor CLI Agent |
There was a problem hiding this comment.
This heading has trailing whitespace. Please remove it for consistent formatting.
| ### 2. Cursor CLI Agent | |
| ### 2. Cursor CLI Agent |
| - **Purpose:** Structured feature requests with clear requirements | ||
| - **Agent-friendly:** Includes implementation guidance and testing strategy | ||
|
|
||
| ### Bug Report Template |
There was a problem hiding this comment.
This heading has trailing whitespace. Please remove it for consistent formatting.
| ### Bug Report Template | |
| ### Bug Report Template |
| ``` | ||
| ``` |
There was a problem hiding this comment.
There appear to be some extraneous, empty code fences at the end of this file. These should be removed to clean up the document.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| async function pool(taskFns, size) { | ||
| let cursor = 0; | ||
| const running = new Set(); | ||
|
|
||
| async function launchNext() { | ||
| if (cursor >= taskFns.length) return; | ||
| const fn = taskFns[cursor++]; | ||
| const promise = fn().finally(() => running.delete(promise)); | ||
| running.add(promise); | ||
| if (running.size < size) { | ||
| await launchNext(); | ||
| } | ||
| } | ||
|
|
||
| const starters = Math.min(size, taskFns.length); | ||
| for (let i = 0; i < starters; i += 1) { | ||
| await launchNext(); |
There was a problem hiding this comment.
The new pool helper never respects its size cap. launchNext() already recurses until running.size reaches the limit, but the subsequent loop still invokes launchNext() size additional times. With 12 tasks and size = 6, this loop pushes five more promises, so 11 image-generation requests fire in parallel instead of six, defeating the throttling and increasing the likelihood of rate-limit or timeout errors. The pool should only start size tasks once and enqueue replacements after a running task settles.
Useful? React with 👍 / 👎.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…css once again compiles tailwind.input.pcss into app.css
This pull request primarily improves project documentation and code formatting standards. The most significant changes are a major rewrite and clarification of the
AGENTS.mdagent rules and workflow documentation, as well as the introduction of a Prettier configuration file to enforce consistent code style. Additionally, minor formatting and clarity improvements were made to theREADME.mdgoals, architecture, and security sections.Documentation improvements:
AGENTS.md: Completely rewritten to clarify coding rules, development workflow, testing approach, and feature development process. Emphasizes a no-build, static workflow, TDD failure loop, and spec-first feature development, with concise, actionable guidelines for contributors.README.md: Reformatted and clarified the MVP goals, non-goals, architecture choices, and security/privacy sections for better readability and maintainability.Tooling and code style:
.prettierrc.json: Added a Prettier configuration to enforce single quotes, trailing commas where valid in ES5, and semicolons, ensuring consistent code formatting across the project.