Skip to content

Commit 59b6503

Browse files
Update crystal-release process (#383)
1 parent 54d475d commit 59b6503

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

processes/crystal-release.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ document. In this way it's easy to track the progress of the release (*Helper:
1111
1. [ ] (minor) Announce expected release date (${RELEASE_DATE}) and time span for feature freeze (starting on ${FREEZE_PERIOD})
1212
* (minor) Feature freeze is about two weeks before release
1313
2. Set date on the milestone
14-
3. [ ] Prepare the changelog entry: (`crystal`) [`scripts/update-changelog.cr ${VERSION}`](https://github.com/crystal-lang/crystal/blob/master/scripts/update-changelog.cr)
14+
3. [ ] Prepare the changelog entry: (`crystal`) [`scripts/update-changelog.cr ${VERSION}`](https://github.com/crystal-lang/crystal/blob/master/scripts/update-changelog.cr) from the HEAD of the release branch (or `master`)
1515
* Ensure that all merged PRs are added to the milestone (check [`is:pr is:merged sort:updated-desc no:milestone`](https://github.com/crystal-lang/crystal/pulls?q=is%3Apr+is%3Amerged+sort%3Aupdated-desc+no%3Amilestone+-label%3Astatus%3Areverted+base%3Amaster+merged%3A%3E%3D2023-01-01)).
1616
* Ensure that all milestoned PRs are properly labelled (check [`is:pr is:merged sort:updated-desc no:label milestone:${VERSION}`](https://github.com/crystal-lang/crystal/pulls?q=is%3Apr+is%3Amerged+sort%3Aupdated-desc+milestone%3A${VERSION}+no%3Alabel)).
1717
* Ensure the milestone has `Due date` set.
18-
4. [ ] Start preparing release notes, publish draft in [`crystal-lang/crystal-website`](https://github.com/crystal-lang/crystal-website/)
18+
4. [ ] Start preparing release notes, publish draft in [`crystal-lang/crystal-website`](https://github.com/crystal-lang/crystal-website/) (summary of changes that are most relevant for users)
1919
5. [ ] (minor) Start feature freeze period (on ${FREEZE_PERIOD})
2020
* (minor) Either no merging of features into `master` or split off release branch for backporting bugfixes.
2121
6. [ ] Publish release PR draft
@@ -57,7 +57,7 @@ document. In this way it's easy to track the progress of the release (*Helper:
5757

5858
### Binary releases
5959

60-
3. Publish build artifacts from CircleCI and GitHub Actions to GitHub release. For `URL_TO_CIRCLECI_ARTIFACT` grab the URL
60+
1. Publish build artifacts from CircleCI and GitHub Actions to GitHub release. For `URL_TO_CIRCLECI_ARTIFACT` grab the URL
6161
of any of the build artifacts in circleCI (doesn't matter which).
6262
* [ ] Upload build artifacts from CircleCI: (`crystal`) [`../distribution-scripts/processes/scripts/publish-crystal-packages-on-github.sh $URL_TO_CIRCLECI_ARTIFACT`](https://github.com/crystal-lang/distribution-scripts/blob/master/processes/scripts/publish-crystal-packages-on-github.sh) (run from `crystallang/crystal@${VERSION}` work tree)
6363
* `crystal-*-darwin-*.tar.gz`
@@ -146,7 +146,7 @@ document. In this way it's easy to track the progress of the release (*Helper:
146146
git commit -m 'Merge `release/${VERSION%.*}` into master'
147147
git log --graph --decorate --pretty=oneline --abbrev-commit
148148
git push -u upstream merge/${VERSION}
149-
gh pr create --title 'Merge `release/${VERSION%.*}` into master' --label 'topic:infrastructure'
149+
gh pr create --title 'Merge `release/${VERSION%.*}`@`%{VERSION} into `master`' --label 'topic:infrastructure'
150150
```
151151
- Merge PR **locally**:
152152
```sh

0 commit comments

Comments
 (0)