Skip to content

Error in method newWallet #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Azariil opened this issue Jun 19, 2017 · 3 comments
Open

Error in method newWallet #1

Azariil opened this issue Jun 19, 2017 · 3 comments

Comments

@Azariil
Copy link

Azariil commented Jun 19, 2017

You changed the method getWallets but in the newWallet method you call the getWallets method without the callback function.
let savedWallets = trantor.getWallets();
change
let savedWallets = trantor.getWallets(function(){});

@Azariil
Copy link
Author

Azariil commented Jun 19, 2017

In the same method, you call return before you write data to the database.

return {wif: wif, address: address};
  db.run("INSERT INTO wallets (address, wif) VALUES ('"+address+"', '"+wif+"')",
    (error, row) => {});

@nombrekeff
Copy link
Contributor

Ok, thanks for the report, im on it

@nombrekeff
Copy link
Contributor

Okey its fixed, now it also expects a callback to be passed, when calling newWallet

trantor.newWallet(function(wallet){})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants