Skip to content

Fully remove app.go configurators #617

@vladjdk

Description

@vladjdk

Remove configurators from app.go to prevent bloating of boilerplate code in chain setups:

evm/evmd/app.go

Lines 265 to 268 in fc87a64

// initialize the Cosmos EVM application configuration
if err := chainConfig.ApplyChainConfig(); err != nil {
panic(err)
}

  • To be set in VM module genesis
    • Chainconfig initialization and global variable setting
    • Chain ID to be stored in the genesis for the module
    • Decimal info to be derived from the bank module genesis and set in the module
      • You should be able to get denom information from the decimals set in bank. We could even force people to define an 18-decimal coin alongside their custom decimal coin (if it exists) and panic if an 18-decimal denom does not exist.
      • From here, we could use this in precisebank
    • ExtraEIPs should reside as default objects within the VM module and only be overrideable via custom code if necessary
      • Activators should be the same. Initialize these in the module itself.

At the end of the day, all of these configs are only used by the VM and adjacent modules (geth, erc20, precisebank)—none of which are used without the VM module. Therefore, all of these configurators should be removed from app.go and placed into VM module initialization.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions