Skip to content

Commit cdcacaa

Browse files
Merge pull request #126 from contentstack/development
DX | 01-09-2025 | Release
2 parents cf3b3e0 + afb0fdf commit cdcacaa

File tree

7 files changed

+456
-165
lines changed

7 files changed

+456
-165
lines changed

.github/workflows/node.js.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,11 @@ jobs:
2323
uses: actions/[email protected]
2424
with:
2525
node-version: ${{ matrix.node-version }}
26-
- run: |
26+
- run: |
2727
rm -rf node_modules package-lock.json
2828
npm i
29-
- run: npm test
29+
- name: Run tests with coverage
30+
run: npm run test:unit:report:json
3031
env:
3132
TOKEN: ${{secrets.TOKEN}}
3233
TOKEN_WITH_NO_CT: ${{secrets.TOKEN_WITH_NO_CT}}
@@ -36,3 +37,9 @@ jobs:
3637
REGION: ${{secrets.REGION}}
3738
TOKENTYPE: ${{secrets.TOKENTYPE}}
3839
BRANCH: ${{secrets.BRANCH}}
40+
41+
- name: Coverage Report
42+
uses: lucassabreu/comment-coverage-clover@main
43+
if: github.event_name == 'pull_request'
44+
with:
45+
file: coverage/clover.xml

.talismanrc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ fileignoreconfig:
33
ignore_detectors:
44
- filecontent
55
- filename: package-lock.json
6-
checksum: c447ed3d22eef9d2b26b9ae85370de31be04cc94da0af506ada0025bc7a9bbb6
6+
checksum: 371b37886fa8b6f93b82fa66fd82484126809f29b01fd34dfa53322132dccb2e
77
- filename: .husky/pre-commit
88
checksum: 5baabd7d2c391648163f9371f0e5e9484f8fb90fa2284cfc378732ec3192c193
99
- filename: src/graphqlTS/index.ts
@@ -20,4 +20,6 @@ fileignoreconfig:
2020
checksum: 7c1bc7d659ee2f9f52bf644b9e512984f89e0ff6aa4288b6e30b2c899bf80123
2121
- filename: src/generateTS/shared/utils.ts
2222
checksum: da69dab1717422e12f3b3865604667151d46c96bde5faba13ae862c41d856fba
23+
- filename: tests/unit/generateTS/generateTS.test.ts
24+
checksum: 10e5139168a951a488760626d8305f379db1a7e5df626feb63ef55409ab76a03
2325
version: "1.0"

package-lock.json

Lines changed: 269 additions & 104 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@contentstack/types-generator",
3-
"version": "3.7.0",
3+
"version": "3.7.1",
44
"description": "Contentstack type definition generation library",
55
"private": false,
66
"author": "Contentstack",
@@ -11,7 +11,8 @@
1111
"prepare": "npm run build",
1212
"build": "tsup",
1313
"husky-check": "npx husky && chmod +x .husky/pre-commit",
14-
"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathPattern=tests"
14+
"test": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathPattern=tests",
15+
"test:unit:report:json": "cross-env NODE_OPTIONS=--experimental-vm-modules jest --testPathPattern=tests/unit --coverage --coverageReporters=clover --coverageReporters=json --coverageDirectory=coverage --testResultsProcessor=jest-json-reporter --outputFile=test-results.json"
1516
},
1617
"repository": {
1718
"type": "git",
@@ -39,6 +40,7 @@
3940
"dotenv": "^16.6.1",
4041
"husky": "^9.1.7",
4142
"jest": "^29.7.0",
43+
"jest-json-reporter": "^1.2.2",
4244
"nock": "^13.5.6",
4345
"rollup": "^4.48.0",
4446
"ts-jest": "^29.4.0",

src/generateTS/factory.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -546,21 +546,13 @@ export default function (userOptions: TSGenOptions) {
546546
if (options.includeReferencedEntry) {
547547
const referencedEntryType = `${options.naming?.prefix || ""}ReferencedEntry`;
548548

549-
const wrapWithReferencedEntry = (refType: string) =>
550-
`(${refType} | ${referencedEntryType})`;
551-
552-
const types =
553-
references.length === 1
554-
? wrapWithReferencedEntry(references[0])
555-
: references.map(wrapWithReferencedEntry).join(" | ");
549+
const baseUnion = references.join(" | ");
550+
const types = `(${baseUnion} | ${referencedEntryType})`;
556551

557552
return `${types}[]`;
558553
}
559-
560-
const baseType =
561-
references.length === 1 ? references[0] : references.join(" | ");
562-
563-
return `${baseType}[]`;
554+
const baseUnion = references.join(" | ");
555+
return `(${baseUnion})[]`;
564556
}
565557

566558
function type_reference(field: ContentstackTypes.Field) {

0 commit comments

Comments
 (0)