fix: cleanup (#419)

Author: Guillermo Moraleda

Sources/Contentful/ArrayResponse.swift

@@ -147,7 +147,7 @@ extension HomogeneousArrayResponse: Decodable {
                     """
                     throw SDKError.unparseableJSON(data: nil, errorMessage: errorMessage)
                 }
-                let entryDecodable = try entryDecodableType.popEntryDecodable(from: &entriesJSONContainer)
+                let entryDecodable = try entriesJSONContainer.decode(entryDecodableType)
                 entries.append(entryDecodable)
             }
 
@@ -331,7 +331,7 @@ extension KeyedDecodingContainer {
             // For includes, if the type of this entry isn't defined by the user, we skip serialization.
             if let type = contentTypes[contentTypeInfo.id] {
                 do {
-                    let entryModellable = try type.popEntryDecodable(from: &entriesJSONContainer)
+                    let entryModellable = try entriesJSONContainer.decode(type)
                     entries.append(entryModellable)
                 } catch {
                     if throwIfNotPresent {

Sources/Contentful/Date.swift

@@ -53,7 +53,6 @@ public extension Date {
         let dateString = try container.decode(String.self)
 
         let timeZone = decoder.timeZone
-        let formatter = Date.iso8601Formatter(timeZone: timeZone)
 
         for format in Date.supportedFormats {
             let formatter = DateFormatterCache.shared.get(format, timeZone: timeZone)

Sources/Contentful/Decodable.swift

@@ -79,16 +79,6 @@ public extension JSONDecoder {
     }
 }
 
-public extension Decodable where Self: EntryDecodable {
-    // This is a magic workaround for the fact that dynamic metatypes cannot be passed into
-    // initializers such as UnkeyedDecodingContainer.decode(Decodable.Type), yet static methods CAN
-    // be called on metatypes. (Visitor pattern)
-    static func popEntryDecodable(from container: inout UnkeyedDecodingContainer) throws -> Self {
-        let entryDecodable = try container.decode(self)
-        return entryDecodable
-    }
-}
-
 extension Decodable where Self: AssetDecodable {
     static func popAssetDecodable(from container: inout UnkeyedDecodingContainer) throws -> Self {
         let assetDecodable = try container.decode(self)