File tree Expand file tree Collapse file tree 2 files changed +18
-5
lines changed Expand file tree Collapse file tree 2 files changed +18
-5
lines changed Original file line number Diff line number Diff line change @@ -4,6 +4,10 @@ Changelog
4
4
1.3 (unreleased)
5
5
----------------
6
6
7
+ - Improve the error messages for the GracefulResourceRenderer to give an admin
8
+ better hints on what was going wrong.
9
+ [thet]
10
+
7
11
- Do not wrap resource ``__repr__ `` output in ``<> `` to render tracebacks
8
12
properly in browser.
9
13
[lenadax]
@@ -68,7 +72,7 @@ Changelog
68
72
Modernize setup.[py|cfg].
69
73
[jensens]
70
74
71
- - Added ``GracefulResourceRenderer ``.
75
+ - Added ``GracefulResourceRenderer ``.
72
76
Fixes #1.
73
77
[jensens]
74
78
Original file line number Diff line number Diff line change @@ -738,10 +738,19 @@ class GracefulResourceRenderer(ResourceRenderer):
738
738
def render (self ):
739
739
lines = []
740
740
for resource in self .resolver .resolve ():
741
+ error_message = None
741
742
try :
742
743
lines .append (resource .render (self .base_url ))
743
- except (ResourceError , FileNotFoundError ):
744
- msg = u'Failure to render resource "{}"' .format (resource .name )
745
- lines .append (u'<!-- {} - details in logs -->' .format (msg ))
746
- logger .exception (msg )
744
+ except FileNotFoundError :
745
+ error_message = u'File not found for resource "{}"' .format (
746
+ resource .name
747
+ )
748
+ except ResourceError as e :
749
+ error_message = str (e )
750
+ finally :
751
+ if error_message :
752
+ lines .append (u'<!-- {} - details in logs -->' .format (
753
+ error_message
754
+ ))
755
+ logger .exception (error_message )
747
756
return u'\n ' .join (lines )
You can’t perform that action at this time.
0 commit comments