From 9fdb9106b4552b951efd2f0b54aad4d2e3b27e07 Mon Sep 17 00:00:00 2001 From: Sylwester Lachiewicz Date: Mon, 3 Nov 2025 22:52:37 +0000 Subject: [PATCH] JUnit Jupiter best practices Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.java.testing.junit.JupiterBestPractices?organizationId=NzQ1YmJlODUtZjNkMy00OTNkLThhNDAtZWJmZDg4N2U1ZjU1 Co-authored-by: Moderne --- .../internal/DefaultSecDispatcherTest.java | 2 +- .../components/secdispatcher/internal/SecUtilTest.java | 6 +++--- .../internal/cipher/CipherTestSupport.java | 6 +++--- .../internal/dispatchers/LegacyDispatcherTest.java | 2 +- .../dispatchers/MasterSourceLookupDispatcherTest.java | 10 +++++----- .../secdispatcher/internal/sources/SourcesTest.java | 2 +- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcherTest.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcherTest.java index 5b98639..61cf2b5 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcherTest.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/DefaultSecDispatcherTest.java @@ -42,7 +42,7 @@ import static org.junit.jupiter.api.Assertions.assertFalse; import static org.junit.jupiter.api.Assertions.assertTrue; -public class DefaultSecDispatcherTest { +class DefaultSecDispatcherTest { private final Path CONFIG_PATH = Paths.get("./target/sec.xml"); private void saveSec(String dispatcher, Map config) throws Exception { diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/SecUtilTest.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/SecUtilTest.java index 4587c87..fa18f10 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/SecUtilTest.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/SecUtilTest.java @@ -36,7 +36,7 @@ * @version $Id$ * */ -public class SecUtilTest { +class SecUtilTest { String _confName = "cname"; String _propName = "pname"; String _propVal = "pval"; @@ -64,7 +64,7 @@ void prepare() throws IOException { } @Test - void readWrite() throws IOException { + void readWrite() throws Exception { Path path = Path.of("./target/sec.xml"); SettingsSecurity config = SecUtil.read(path); assertNotNull(config); @@ -75,7 +75,7 @@ void readWrite() throws IOException { } @Test - void readWriteWithBackup() throws IOException { + void readWriteWithBackup() throws Exception { Path path = Path.of("./target/sec.xml"); SettingsSecurity config = SecUtil.read(path); assertNotNull(config); diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/cipher/CipherTestSupport.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/cipher/CipherTestSupport.java index 9e8693f..044f5b9 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/cipher/CipherTestSupport.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/cipher/CipherTestSupport.java @@ -41,7 +41,7 @@ void prepare() { abstract Cipher getCipher(); @Test - void testEncrypt() throws Exception { + void encrypt() throws Exception { String enc = pbeCipher.encrypt(clearText, password); assertNotNull(enc); String enc2 = pbeCipher.encrypt(clearText, password); @@ -50,14 +50,14 @@ void testEncrypt() throws Exception { } @Test - void testDecrypt() throws Exception { + void decrypt() throws Exception { String enc = pbeCipher.encrypt(clearText, password); String clear = pbeCipher.decrypt(enc, password); assertEquals(clearText, clear); } @Test - void testEncoding() throws Exception { + void encoding() throws Exception { String pwd = "äüöÜÖÄæøåčćžšđß\"§$%&/()=?é"; String encPwd = pbeCipher.encrypt(pwd, pwd); String decPwd = pbeCipher.decrypt(encPwd, pwd); diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcherTest.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcherTest.java index 62336ea..9c77c71 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcherTest.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/LegacyDispatcherTest.java @@ -20,7 +20,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals; -public class LegacyDispatcherTest { +class LegacyDispatcherTest { /** * Test values created with Maven 3.9.9. *

diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/MasterSourceLookupDispatcherTest.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/MasterSourceLookupDispatcherTest.java index 7c4fae6..ff021ef 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/MasterSourceLookupDispatcherTest.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/dispatchers/MasterSourceLookupDispatcherTest.java @@ -25,10 +25,10 @@ import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; -public class MasterSourceLookupDispatcherTest { +class MasterSourceLookupDispatcherTest { @Test - void testUnknownPrefix() { + void unknownPrefix() { MasterSourceLookupDispatcher masterSourceLookupDispatcher = new MasterSourceLookupDispatcher(Collections.singleton(new EnvMasterSource())); assertThrows( @@ -40,7 +40,7 @@ void testUnknownPrefix() { } @Test - void testSystemPropertyMasterSourceDecrypt() { + void systemPropertyMasterSourceDecrypt() { System.setProperty("myprop", "plaintext"); MasterSourceLookupDispatcher masterSourceLookupDispatcher = new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource())); @@ -50,7 +50,7 @@ void testSystemPropertyMasterSourceDecrypt() { } @Test - void testEncrypt() { + void encrypt() { System.setProperty("myprop", "plaintext"); MasterSourceLookupDispatcher masterSourceLookupDispatcher = new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource())); @@ -60,7 +60,7 @@ void testEncrypt() { } @Test - void testValidateConfiguration() { + void validateConfiguration() { MasterSourceLookupDispatcher masterSourceLookupDispatcher = new MasterSourceLookupDispatcher(Collections.singleton(new SystemPropertyMasterSource())); ValidationResponse response = masterSourceLookupDispatcher.validateConfiguration(Collections.emptyMap()); diff --git a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/sources/SourcesTest.java b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/sources/SourcesTest.java index 8869042..226ad0c 100644 --- a/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/sources/SourcesTest.java +++ b/src/test/java/org/codehaus/plexus/components/secdispatcher/internal/sources/SourcesTest.java @@ -21,7 +21,7 @@ /** * surefire plugin set system property and env. */ -public class SourcesTest { +class SourcesTest { @Test void systemProperty() { SystemPropertyMasterSource source = new SystemPropertyMasterSource();