Address code review: Keep REPLACE_EXISTING as fallback for robustness

Copilot · slachiewicz · Copilot · commit 882221ce02ed · 2025-10-27T01:52:23.000Z
Co-authored-by: slachiewicz &lt;6705942+slachiewicz@users.noreply.github.com&gt;
diff --git a/src/main/java/org/codehaus/plexus/archiver/AbstractUnArchiver.java b/src/main/java/org/codehaus/plexus/archiver/AbstractUnArchiver.java
@@ -38,6 +38,8 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
+
 // TODO there should really be constructors which take the source file.
 
 /**
@@ -327,7 +329,7 @@ protected void extractFile(
                 if (targetFileName.exists()) {
                     targetFileName.delete();
                 }
-                Files.copy(compressedInputStream, targetFileName.toPath());
+                Files.copy(compressedInputStream, targetFileName.toPath(), REPLACE_EXISTING);
             }
 
             targetFileName.setLastModified(entryDate.getTime());

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,8 @@`
`38`	`38`	`import org.slf4j.Logger;`
`39`	`39`	`import org.slf4j.LoggerFactory;`
`40`	`40`
	`41`	`+import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;`
	`42`	`+`
`41`	`43`	`// TODO there should really be constructors which take the source file.`
`42`	`44`
`43`	`45`	`/**`
`@@ -327,7 +329,7 @@ protected void extractFile(`
`327`	`329`	`if (targetFileName.exists()) {`
`328`	`330`	`targetFileName.delete();`
`329`	`331`	`}`
`330`		`- Files.copy(compressedInputStream, targetFileName.toPath());`
	`332`	`+ Files.copy(compressedInputStream, targetFileName.toPath(), REPLACE_EXISTING);`
`331`	`333`	`}`
`332`	`334`
`333`	`335`	`targetFileName.setLastModified(entryDate.getTime());`