A few suggestions for your awesome project #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use scissors icon instead of emoji in the title - Changes to docker - Add .dockerignore to skip copping unwanted files to container - Use python:3.9-slim for a smaller container - Automatically download u2net.onx during container build - Use gunicorn to serve the app instead of the flask dev server - Adding gunicorn to serve the flask app. This brings a production level server to host the app, instead of the flask dev server. - Update Readme with notes about how to run with a container or locally - Adding .devcontainer for Codespaces and/or locally working from WSL or a dev container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watch your video and had a few ideas/suggestions for the repo.
It looks like some of them are also suggested in other PRs already (should've taken a look to existing PRs first :)