merge all mouse motion to one #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmave
reviewed
Nov 10, 2025
Member
schmave
left a comment
schmave
left a comment
There was a problem hiding this comment.
Thanks so much for noticing this bug and taking the time to send a fix! I really appreciate it.
Is it possible to change fewer lines of code? It's always nice when there is less to retest. The code related to calling onMouseMove and onMouseDrag has to move, but could the rest of the events be left where they are?
cmu_graphics/cmu_graphics.py
Outdated
| if event.buttons == (0, 0, 0): | ||
| self.callUserFn('onMouseMove', event.pos) | ||
| else: | ||
| print("DRAG") |
Member
There was a problem hiding this comment.
Please remove this print statement
Author
If the issues arent addressed yet, i will try to find out whats the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks timing to call mouse events.
Since there can be multiple
MOUSEMOTIONevents in thepygame.events.get(), I've merged all of them into one.Fix #125