diff --git a/.eslintrc b/.eslintrc index 0586164..869c011 100644 --- a/.eslintrc +++ b/.eslintrc @@ -18,7 +18,12 @@ "rules": { "@typescript-eslint/no-empty-function": "off", "@typescript-eslint/no-namespace": "off", - "@typescript-eslint/no-unused-vars": "error", + "@typescript-eslint/no-unused-vars": [ + "error", + { + "caughtErrors": "all" + } + ], "@typescript-eslint/consistent-type-definitions": ["error", "interface"], "@typescript-eslint/explicit-module-boundary-types": "off", "@typescript-eslint/no-explicit-any": "off", diff --git a/src/internal/analytics-metadata/dom-utils.ts b/src/internal/analytics-metadata/dom-utils.ts index b153dac..f224dca 100644 --- a/src/internal/analytics-metadata/dom-utils.ts +++ b/src/internal/analytics-metadata/dom-utils.ts @@ -10,7 +10,7 @@ export const findLogicalParent = (node: HTMLElement): HTMLElement | null => { return (node.ownerDocument || node).querySelector(`[id="${referrer}"]`); } return node.parentElement; - } catch (ex) { + } catch { return null; } }; @@ -31,7 +31,7 @@ export const isNodeComponent = (node: HTMLElement): boolean => { try { const metadata = JSON.parse(metadataString); return !!metadata.component && !!metadata.component.name; - } catch (ex) { + } catch { return false; } }; diff --git a/src/internal/analytics-metadata/testing-utils.ts b/src/internal/analytics-metadata/testing-utils.ts index a4033a3..9409c34 100644 --- a/src/internal/analytics-metadata/testing-utils.ts +++ b/src/internal/analytics-metadata/testing-utils.ts @@ -23,7 +23,7 @@ export const getRawAnalyticsMetadata = (target: HTMLElement | null): RawAnalytic output.metadata.push(currentMetadata); output.labelSelectors = [...output.labelSelectors, ...getLabelSelectors(currentMetadata)]; } - } catch (ex) { + } catch { /* empty */ } finally { currentNode = findLogicalParent(currentNode); diff --git a/src/internal/analytics-metadata/utils.ts b/src/internal/analytics-metadata/utils.ts index 19bb318..3fbec90 100644 --- a/src/internal/analytics-metadata/utils.ts +++ b/src/internal/analytics-metadata/utils.ts @@ -19,7 +19,7 @@ export const getGeneratedAnalyticsMetadata = (target: HTMLElement | null): Gener const currentMetadata = JSON.parse(currentMetadataString); metadata = mergeMetadata(metadata, processMetadata(currentNode, currentMetadata)); } - } catch (ex) { + } catch { /* empty */ } finally { currentNode = findLogicalParent(currentNode); diff --git a/src/internal/base-component/metrics/log-clients.ts b/src/internal/base-component/metrics/log-clients.ts index cb11005..211c9b7 100644 --- a/src/internal/base-component/metrics/log-clients.ts +++ b/src/internal/base-component/metrics/log-clients.ts @@ -80,7 +80,7 @@ export class CLogClient { } return this.findAWSC(currentWindow.parent); - } catch (ex) { + } catch { // Most likely a cross-origin access error return undefined; } @@ -154,7 +154,7 @@ export class PanoramaClient { } return this.findPanorama(currentWindow.parent); - } catch (ex) { + } catch { // Most likely a cross-origin access error return undefined; } diff --git a/src/internal/global-flags/index.ts b/src/internal/global-flags/index.ts index 4c597f2..feee136 100644 --- a/src/internal/global-flags/index.ts +++ b/src/internal/global-flags/index.ts @@ -34,7 +34,7 @@ export const getGlobalFlag = (flagName: keyof GlobalFlags): GlobalFlags[keyof Gl return ownFlag; } return readFlag(getTopWindow(), flagName); - } catch (e) { + } catch { return undefined; } }; diff --git a/src/internal/keycode.ts b/src/internal/keycode.ts index c7a000c..613dca4 100644 --- a/src/internal/keycode.ts +++ b/src/internal/keycode.ts @@ -24,5 +24,5 @@ export enum KeyCode { export function isModifierKey(event: KeyboardEvent) { // we do not want to highlight focused element // when special keys are pressed - return [KeyCode.shift, KeyCode.alt, KeyCode.control, KeyCode.meta].indexOf(event.keyCode) > -1; + return [KeyCode.shift, KeyCode.alt, KeyCode.control, KeyCode.meta].includes(event.keyCode); } diff --git a/src/internal/stable-callback/index.ts b/src/internal/stable-callback/index.ts index a4ed990..f19c5f5 100644 --- a/src/internal/stable-callback/index.ts +++ b/src/internal/stable-callback/index.ts @@ -35,5 +35,5 @@ export function useStableCallback any>(fn: ref.current = fn; }); - return useCallback((...args: any[]) => ref.current?.apply(undefined, args), []) as Callback; + return useCallback((...args: any[]) => ref.current?.(...args), []) as Callback; }