Skip to content

Inline routing-release submodules #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task
maxmoehl opened this issue Feb 27, 2025 · 3 comments
Open
1 task

Inline routing-release submodules #459

maxmoehl opened this issue Feb 27, 2025 · 3 comments
Assignees

Comments

@maxmoehl
Copy link
Member

maxmoehl commented Feb 27, 2025

Proposed Change

Instead of maintaining many repositories, inline the submodules into the release to reduce the overhead of managing multiple repositories and making changes which affect all of them.

Acceptance criteria

Less (or no) submodules.

Related links

Batch 1:

Batch 2:

Batch 3:

Remaining:

Follow-ups:

  • Should we inline all sub-modules, we should remove automation for it as well.
@peanball
Copy link
Contributor

Please also add a task for updating the routing-release pipeline.
Submodules are bumped here, among other things: bump-dependencies-go-mod.

I don't think it will break, but maybe we can then get rid of some dead code.

@maxmoehl
Copy link
Member Author

maxmoehl commented Mar 6, 2025

We briefly talked about this in the WG Forum:

  • routing-api and routing-info are also submodules of diego-release so we won't be able to inline them.
  • I will check and add a warning to gorouter and route-registrar that we will inline them soon and people should wait with opening PRs.
  • Once the outstanding PRs (primarily prometheus protobuf changes) are merged I will inline them as well.

It should be possible to migrate feature branches. If I find the time I will try it out and document the process should anyone have a branch in a fork they want to migrate after the inlining.

@maxmoehl maxmoehl moved this from Inbox to Waiting for Changes | Open for Contribution in Application Runtime Platform Working Group Mar 6, 2025
maxmoehl added a commit to sap-contributions/wg-app-platform-runtime-ci that referenced this issue Apr 14, 2025
plowin pushed a commit to cloudfoundry/wg-app-platform-runtime-ci that referenced this issue Apr 16, 2025
maxmoehl added a commit to sap-contributions/wg-app-platform-runtime-ci that referenced this issue Apr 17, 2025
plowin pushed a commit to cloudfoundry/wg-app-platform-runtime-ci that referenced this issue Apr 17, 2025
* revert: fix: remove repos which have been inlined (#64)

This reverts commit ddc516d.

* ci: fix docs and submodule sync

See: cloudfoundry/routing-release#459
@maxmoehl
Copy link
Member Author

If you had changes for one of the repos which has been inlined you can migrate them:

First make sure you are on the current tip of the development branch. Inside routing-release (assuming you want to migrate my-branch from gorouter) you can run:

git switch -c my-branch
git subtree pull --prefix src/code.cloudfoundry.org/gorouter https://github.com/cloudfoundry/gorouter my-branch

Should your change be on a fork you have to replace the URL with the URL from your fork. This will create a merge commit on your branch from which you can then open a PR to routing-release.

maxmoehl added a commit to sap-contributions/routing-release that referenced this issue Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting for Changes | Open for Contribution
Development

No branches or pull requests

2 participants